Change the node LSP for the native binaries #7

[AntoineGS]

Since native binaries are now available (here) figured it would be best to use them as it means fewer dependencies (no need for node) and hopefully less overhead so better performance.
I included the binaries as part of the report though I am not sure that is ideal.
But since the LSP was already included I figured it's no different than before except now there are 5 versions.
Hopefully I got the os detection logic right, as I do not have access to most of the architectures to test.

Seems to fix #309 as well!

[zbirenbaum]

Awesome work, thank you so much!! My one note is that I think it's pretty important for a project that is supplying prebuilt binaries to do so through an automated update script which pulls down the files directly or performs some setup step through a user command like :copilot install-deps or something. There was a recent instance of a plugin with malicious software:

https://www.reddit.com/r/neovim/comments/1j45stl/someone_wrote_malicious_code_in_the_neovim_plugin/?rdt=38437

If you want to go ahead and merge this as just this once feel free to, I see you have a ton of awesome PRs in flight and don't want to make too much extra work for you to get these in.

[AntoineGS]

Thank for the feedback! It makes complete sense to automate this through an update script for security reasons, I will work on that :P
Yeah I took a liking to the project as you can see 😂 It's well built and fun to maintain/add features.

[zbirenbaum]

Thank for the feedback! It makes complete sense to automate this through an update script for security reasons, I will work on that :P Yeah I took a liking to the project as you can see 😂 It's well built and fun to maintain/add features.

No worries. I actually can't seem to download your branch. The binaries are way too huge for Lazy to handle in a timely manner and it looked like it was frozen for a solid minute at 100% resolving delta. I'm going to be firm that this should be done through a separate script which only downloads the binary for your platform

[AntoineGS]

@zbirenbaum I think I got it, the file gymnastics was trickier than I expected but it seems to have fixed another issue at the same time with the WSL authentication.
I have tested on both Linux and Windows and the files management seems OK!
Would you mind doing a test on that one?
Since that change is more core than others it would be ideal to have another person test it :)

Edit: I am not sure what the conflict is with master 😣, since I even merged master into it minutes ago.
If you see what it is let know.

[mirkolenz]

Thanks for your recent improvements to this repo! In case you haven't seen it already: It seems that setting the integration id is no longer necessary:

community/community#151719 (reply in thread)

Just wanted to let you know in case it's relevant for these upcoming changes in this PR.

[AntoineGS]

Thanks for the info!
I've been testing the upgrade to the new version (1.291) but some other APIs have changed so I have not yet committed it but it is on the way :P

[ornicar]

Unfortunately this breaks functionality on NixOs. Copilot doesn't start, here's the contents of ~/.local/state/nvim/lsp.log:

[START][2025-03-27 09:49:34] LSP logging initiated
[ERROR][2025-03-27 09:49:34] .../vim/lsp/rpc.lua:770	"rpc"	"/home/thib/.local/share/nvim/lazy/copilot.lua/copilot/linux-x64/copilot-language-server-1.292.0"	"stderr"	"Could not start dynamically linked executable: /home/thib/.local/share/nvim/lazy/copilot.lua/copilot/linux-x64/copilot-language-server-1.292.0\nNixOS cannot run dynamically linked executables intended for generic\nlinux environments out of the box. For more information, see:\nhttps://nix.dev/permalink/stub-ld\n"

[mirkolenz]

You can set the lsp binary path yourself, this worked perfectly for me 😄 0e3585b