Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add concurrent-ruby dependency. #835

Closed
wants to merge 2 commits into from
Closed

Add concurrent-ruby dependency. #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70d688e
Add concurrent-ruby dependency.
theturtle32 Jun 5, 2020
d38c88e
Merge branch 'master' into add-concurrent-ruby-dependency
theturtle32 Jun 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/kafka/consumer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
require "kafka/offset_manager"
require "kafka/fetcher"
require "kafka/pause"
require "concurrent"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it can be require "concurrent/map" to avoid loading the whole library, only the Map that is the needed one, wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d like to get rid of the gem dependency altogether. ruby-kafka should be mostly self-contained.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it isn't needed, removal is a way better solution 😉


module Kafka

Expand Down
1 change: 1 addition & 0 deletions ruby-kafka.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ Gem::Specification.new do |spec|
spec.require_paths = ["lib"]

spec.add_dependency 'digest-crc'
spec.add_dependency 'concurrent-ruby', '~> 1.0', '>= 1.0.2'

spec.add_development_dependency "bundler", ">= 1.9.5"
spec.add_development_dependency "rake", "~> 10.0"
Expand Down