Skip to content

Fix getting last message time #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

Darhazer
Copy link
Contributor

@Darhazer Darhazer commented Jun 17, 2020

Fixes #836

It lacks specs though.

`try` is from ActiveSupport which is a development dependency.
Use a simple nil check instead.
@dasch dasch merged commit 07b6077 into zendesk:master Jun 17, 2020
@dasch
Copy link
Contributor

dasch commented Jun 17, 2020

Thanks!

@repeatedly
Copy link
Contributor

When release new version with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create_time instrumentation change in 1.1.0 leading to consumer crash
3 participants