-
Notifications
You must be signed in to change notification settings - Fork 95
feat(avatars): add status indicator component #1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Francois-Esquire
merged 17 commits into
main
from
francois-esquire/avatars-status-indicator
Sep 22, 2022
Merged
feat(avatars): add status indicator component #1410
Francois-Esquire
merged 17 commits into
main
from
francois-esquire/avatars-status-indicator
Sep 22, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jzempel
requested changes
Sep 15, 2022
james-sann
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After overlooking all the feedback from JZ, nothing further on my end @Francois-Esquire! Looks great!
FYI @Francois-Esquire — The Figma component is now in the main Figma branch to reference.
jzempel
requested changes
Sep 19, 2022
jzempel
requested changes
Sep 19, 2022
jzempel
requested changes
Sep 21, 2022
jzempel
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the new
StatusIndicator
standalone component.TODO:
StatusIndicator
design - @james-sann will need your assistance with this!Detail
This PR contains a new component
StatusIndicator
that is exported from theavatars
package. The new component has two propstype
("available" | "away" | "transfers" | "offline"
) andisCompact
.Available

type
:Away

type
:Transfers

type
:Offline

type
:Component frame:

Usage example:

Checklist
designer as a reviewer)
yarn start
)?bedrock
)