Skip to content

feat(avatars): add status indicator component #1410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 22, 2022

Conversation

Francois-Esquire
Copy link
Contributor

@Francois-Esquire Francois-Esquire commented Sep 14, 2022

Description

Adds the new StatusIndicator standalone component.

TODO:

  • add Figma link for StatusIndicator design - @james-sann will need your assistance with this!

Detail

This PR contains a new component StatusIndicator that is exported from the avatars package. The new component has two props type ("available" | "away" | "transfers" | "offline") and isCompact.

Available type:
Screen Shot 2022-09-14 at 2 58 05 PM

Away type:
Screen Shot 2022-09-14 at 2 58 59 PM

Transfers type:
Screen Shot 2022-09-14 at 2 44 43 PM

Offline type:
Screen Shot 2022-09-14 at 2 59 33 PM

Component frame:
Screen Shot 2022-09-14 at 2 43 41 PM

Usage example:
Screen Shot 2022-09-14 at 2 45 05 PM

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@coveralls
Copy link

coveralls commented Sep 14, 2022

Coverage Status

Coverage increased (+0.01%) to 96.099% when pulling 58347d2 on francois-esquire/avatars-status-indicator into 9b5ddae on main.

Copy link

@james-sann james-sann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After overlooking all the feedback from JZ, nothing further on my end @Francois-Esquire! Looks great!

FYI @Francois-Esquire — The Figma component is now in the main Figma branch to reference.

@Francois-Esquire Francois-Esquire merged commit 1c21775 into main Sep 22, 2022
@Francois-Esquire Francois-Esquire deleted the francois-esquire/avatars-status-indicator branch September 22, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants