This repository was archived by the owner on Jan 21, 2020. It is now read-only.
Additional sniffs and tests #10
Merged
+537
−91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
approved these changes
Dec 4, 2018
| <!-- Forbid useless semicolon `;` --> | ||
| <rule ref="SlevomatCodingStandard.PHP.UselessSemicolon"/> | ||
| <!-- Forbid redundant semicolons --> | ||
| <rule ref="WebimpressCodingStandard.PHP.RedundantSemicolon"/> |
There was a problem hiding this comment.
Any reason for replacing these Slevomat tools with Webimpress ones, besides ownership?
Now rulesets are not confliced and cases with spaces around namespace separator pass correctly.
Sniff from webimpress/coding-standard detects also redundant alias for function traits
geerteltink
reviewed
Dec 7, 2018
test/fixed/concatenation-spacing.php
Outdated
| '3'; | ||
| $string = '1' | ||
| . '2' | ||
| . '3'; |
There was a problem hiding this comment.
Shouldn't these two be aligned with the equal sign?
$string = '1'
. '2'
. '3';
There was a problem hiding this comment.
Maybe it should but we don't have any sniff like that... And what if concatenation is in let say sprintf:
throw new \Exception(sprintf(
'This is very very very long error message'
. ' with some exception: %s',
$e->getMessage()
));There is so many cases. ScopeIndent from PHP_CodeSniffer doesn't include so many cases and my is super strict, and controversial in some places ;-) We can try, but ... hah
I think PHP_CodeSniffer needs some adjustments for PHP 7.3
4 tasks
- no spaces around incrementation/decrementation - no spaces after nullable oparator in nullable type declaration
geerteltink
added a commit
that referenced
this pull request
Jan 1, 2019
Additional sniffs and tests
geerteltink
added a commit
that referenced
this pull request
Jan 1, 2019
geerteltink
added a commit
that referenced
this pull request
Jan 1, 2019
|
Thanx @webimpress |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xtreamwayz this is the second part I was talking about
We need to add some test for sniffs - I marked them with
@todotag.Again, documentation is not updated, I can do it later or feel free to do it :)