base: add thrift dependencies #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cfriedt
commented
Jan 24, 2023
cfriedt
force-pushed
the
add-thrift-dependencies
branch
2 times, most recently
from
27f9814 to
5d0c042
Compare
Add the thrift compiler (code generator) as well as host runtime libraries (for running samples on the host). Signed-off-by: Chris Friedt <[email protected]>
cfriedt
force-pushed
the
add-thrift-dependencies
branch
from
5d0c042 to
2acda0b
Compare
stephanosio
reviewed
Jan 27, 2023
| @@ -78,7 +78,8 @@ RUN apt-get -y update && \ | |||
| valgrind \ | |||
| wget \ | |||
| ovmf \ | |||
| xz-utils | |||
| xz-utils \ | |||
| thrift-compiler | |||
There was a problem hiding this comment.
Is this all that is required to build Thrift tests and samples in the CI?
There was a problem hiding this comment.
Yes. If the user wants to run the host-side demos, then there are additional things to install, but they are not required for simply building the Zephyr sample apps. It might be necessary to mark the sample.yaml as build-only though.
This is also required to build the tests, but zephyrproject-rtos/zephyr#54013 includes the support for running the tests in Zephyr.
25 tasks
stephanosio
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the thrift compiler (code generator).