Skip to content

Add toolchain components as Git submodules #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

stephanosio
Copy link
Member

@stephanosio stephanosio commented Mar 15, 2022

This series adds the toolchain components (e.g. binutils, gcc, ...) as Git submodules and updates the crosstool-ng config files to use them.

This allows the toolchain components to be managed in a more centralised manner.

@stephanosio
Copy link
Member Author

stephanosio commented Mar 15, 2022

Re: SRC_CUSTOM
crosstool-ng/crosstool-ng@f17fba6

crosstool-ng PR: zephyrproject-rtos/crosstool-ng#15

@stephanosio stephanosio force-pushed the submodularise_ctng_components branch from 9348d91 to 7ecfd01 Compare March 15, 2022 11:29
This commit pulls in the crosstool-ng patch to make package
`SRC_CUSTOM` option mutually exclusive with `SRC_RELEASE` and
`SRC_DEVEL`.

Signed-off-by: Stephanos Ioannidis <[email protected]>
The `CT_LOCAL_TARBALLS_DIR` configuration is build environment-specific
and should not be specified as a part of the toolchain configurations.

This configuration is specified by the CI script according to the CI
build environment.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds a Git submodule for the binutils pointing to the
commit c7d30a54fc17c1e9d9b1c39c7623222442c63af8.

Signed-off-by: Stephanos Ioannidis <[email protected]>
@stephanosio stephanosio force-pushed the submodularise_ctng_components branch from 7ecfd01 to 57bba4a Compare March 15, 2022 12:23
@stephanosio stephanosio marked this pull request as ready for review March 15, 2022 12:25
@stephanosio stephanosio requested a review from nashif March 15, 2022 12:25
This commit updates the toolchain configurations to use the binutils
Git submodule.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds a Git submodule for the newlib pointing to the
commit 2893dbb10f1fe3bf431a26f89a22e12a5020dc02.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit updates the toolchain configurations to use the newlib Git
submodule.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds a Git submodule for the gcc pointing to the commit
8c1f3dcc6eddf3392d77f56c9bed69e5d6446cdf.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit updates the toolchain configurations to use the gcc Git
submodule.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit adds a Git submodule for the gdb pointing to the commit
8dc5ea2c613782deec380bbad4067e846b0f217e.

Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit updates the toolchain configurations to use the gdb Git
submodule.

Signed-off-by: Stephanos Ioannidis <[email protected]>
@stephanosio stephanosio force-pushed the submodularise_ctng_components branch from 57bba4a to 279c912 Compare March 18, 2022 08:52
@stephanosio stephanosio merged commit 7340560 into zephyrproject-rtos:main Mar 18, 2022
@abrodkin
Copy link
Collaborator

@stephanosio I'd suggest to remove all the branches in Zephyr components forks except related to Zephyr, otherwise it's really confusing:

  1. I guess we're not going to update most of the branches from upstream anyway, even though in upstream they might change. Think of "stable" branches like releases/gcc-10, releases/gcc-11 in GCC.
  2. It's hard to find those really related to Zephyr.

@stephanosio
Copy link
Member Author

@stephanosio I'd suggest to remove all the branches in Zephyr components forks except related to Zephyr, otherwise it's really confusing:

@abrodkin Indeed. I am planning to tidy these up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants