Skip to content

qemu_cortex_r5 excludes too many tests #22037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
andrewboie opened this issue Jan 20, 2020 · 2 comments · Fixed by #20474
Closed
3 tasks done

qemu_cortex_r5 excludes too many tests #22037

andrewboie opened this issue Jan 20, 2020 · 2 comments · Fixed by #20474
Assignees
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@andrewboie
Copy link
Contributor

andrewboie commented Jan 20, 2020

$ cat boards/arm/qemu_cortex_r5/qemu_cortex_r5.yaml 
...
  ignore_tags:
    - benchmark
    - cmsis_rtos
    - interrupt
    - kernel
    - memory_protection
    - userspace

This target should not be excluding so many categories.
For memory_protection and userspace, these tests already have filters which don't run them if the feature isn't supported (CONFIG_ARCH_HAS_USERSPACE, CONFIG_MEMORY_PROTECTION)

the only category that makes sense here is 'benchmark' since QEMU does not provide useful benchmark data

@andrewboie andrewboie added the bug The issue is a bug, or the PR is fixing a bug label Jan 20, 2020
@jhedberg jhedberg added the priority: low Low impact/importance bug label Jan 21, 2020
@stephanosio stephanosio self-assigned this Feb 8, 2020
@stephanosio
Copy link
Member

@andrewboie Most of the above, including the kernel, will be enabled once all the major Cortex-R arch port bugs are addressed (see #20594).

@stephanosio
Copy link
Member

stephanosio commented Feb 10, 2020

Notes on the ignore_tags for the qemu_cortex_r5

stephanosio added a commit to stephanosio/zephyr that referenced this issue Feb 10, 2020
This commit removes the ignore tags for the tests that work after the
changes in the PR zephyrproject-rtos#22037.

Signed-off-by: Stephanos Ioannidis <[email protected]>
andrewboie pushed a commit that referenced this issue Feb 11, 2020
This commit removes the ignore tags for the tests that work after the
changes in the PR #22037.

Signed-off-by: Stephanos Ioannidis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
3 participants