flash_map: pointer dereferencing causes build to fail

[sslupsky]

Describe the bug
A recent change to flash_map is causing build problems. A pointer is not properly declared which causes the build to fail.

zephyr/subsys/storage/flash_map/flash_map_shell.c

Lines 26 to 28 in 5748762

	shell_print(shell, "%-4d %-8d %-20s 0x%-10x 0x%-12x",
	fa->fa_id, fa->fa_device_id, fa->fa_dev->name,
	fa->fa_off, fa->fa_size);

In file included from /Users/stevenslupsky/Documents/source/zephyrproject/zephyr/subsys/storage/flash_map/flash_map_shell.c:7:
/Users/stevenslupsky/Documents/source/zephyrproject/zephyr/subsys/storage/flash_map/flash_map_shell.c: In function 'fa_cb':
/Users/stevenslupsky/Documents/source/zephyrproject/zephyr/subsys/storage/flash_map/flash_map_shell.c:27:46: error: dereferencing pointer to incomplete type 'const struct device'
       fa->fa_id, fa->fa_device_id, fa->fa_dev->name,
                                              ^~

flash_map_shell.c and flash_map.h do not include device.h so the device struct has an incomplete type hence the error. Including device.h in flash_map.h resolves the problem.

@JordanYates FYI. #47193 appears to have caused this issue.

[sslupsky]

Also, the fa->fa_off argument is throwing a Wformat warning. I am compiling on arm32 and the sizes are actually correct but the compiler is generating a warning. Probably should type cast the argument?

[fabiobaltieri]

FYI @de-nordic.