Skip to content

Bluetooth: Controller: ISO: BIG Complete event contains invalid/unset values #81023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Thalley opened this issue Nov 6, 2024 · 3 comments · Fixed by #85358 or #85300
Closed

Bluetooth: Controller: ISO: BIG Complete event contains invalid/unset values #81023

Thalley opened this issue Nov 6, 2024 · 3 comments · Fixed by #85358 or #85300
Assignees
Labels
area: Bluetooth Controller area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug

Comments

@Thalley
Copy link
Collaborator

Thalley commented Nov 6, 2024

Describe the bug
When the controller finished setting up the BIG, it sends a BIG Complete Event which is parsed by the host, but the event is missing some values / some values are uninitialized.

To Reproduce

  1. Build and run zephyr/tests/bsim/bluetooth/host/iso/bis/tests_scripts/bis.sh with tests: Bluetooth: ISO: Add validation of broadcast info #80999
  2. See error

Expected behavior
Expect that all values in the event are valid

Impact
Not insignificant as the values are expose to the application layer

Logs and console output

d_00: @00:00:00.013751  [00:00:00.013,732] <inf> bis_broadcaster: ISO Channel 0x81a689c connected
d_00: @00:00:00.013947 ERROR: (WEST_TOPDIR/zephyr/tests/bsim/bluetooth/host/iso/bis/src/bis_broadcaster.c:229): Invalid ISO interval 0x0000
d_00: @00:00:00.013947  The TESTCASE FAILED (test return code 2)

Environment (please complete the following information):

Additional context
N/A

@Thalley Thalley added bug The issue is a bug, or the PR is fixing a bug area: Bluetooth area: Bluetooth Controller area: Bluetooth ISO Bluetooth LE Isochronous Channels labels Nov 6, 2024
@Thalley
Copy link
Collaborator Author

Thalley commented Nov 6, 2024

@cvinayak this also seems to be an issue for unicast: #81029 where both c to p and p to c latencies are 0.

@cvinayak
Copy link
Collaborator

@Thalley can you confirm if this issue can now be closed, fixed by #85300 and #85358 ?

@Thalley
Copy link
Collaborator Author

Thalley commented Feb 13, 2025

@Thalley can you confirm if this issue can now be closed, fixed by #85300 and #85358 ?

My PR, #80999, is now passing CI so looks like the BIG complete event now contains all valid values :)

@Thalley Thalley closed this as completed Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Controller area: Bluetooth ISO Bluetooth LE Isochronous Channels area: Bluetooth bug The issue is a bug, or the PR is fixing a bug priority: low Low impact/importance bug
Projects
None yet
3 participants