tests: Bluetooth: ISO: Add validation of unicast info #81029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
6b89acc to
b3c1e05
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
9942c46 to
ec4105b
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
ec4105b to
ed46fef
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
ed46fef to
85730cf
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
85730cf to
63c688a
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
914d1d5 to
acc88d1
Compare
Thalley
force-pushed
the
iso_unicast_info_validation
branch
2 times, most recently
from
b41ce81 to
bd3ab72
Compare
Add validation of the info the application can retrieve by calling bt_iso_chan_get_info. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
iso_unicast_info_validation
branch
from
bd3ab72 to
f6525a7
Compare
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/bsim/bluetooth/host/iso/cis/src/cis_central.c:270
- [nitpick] Consider renaming 'set_cig_defaults' to 'init_cig_param_defaults' to clarify that it initializes the global cig_param and resets all default values.
static void set_cig_defaults(void)
tests/bsim/bluetooth/host/iso/cis/src/cis_central.c:153
- [nitpick] Verify that the assertion checking 'info.iso_interval % cig_param.c_to_p_interval' correctly reflects the intended relationship between the ISO interval and the SDU interval. Its behavior differs from the peripheral test where flush_timeout is validated, so ensure both tests consistently enforce the correct parameter relationship.
TEST_ASSERT((info.iso_interval % cig_param.c_to_p_interval) == 0U,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add validation of the info the application can retrieve by calling bt_iso_chan_get_info.