Skip to content

nrf_wifi requires long deprecated variable #87950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nordicjm opened this issue Apr 1, 2025 · 0 comments · Fixed by #88021
Closed

nrf_wifi requires long deprecated variable #87950

nordicjm opened this issue Apr 1, 2025 · 0 comments · Fixed by #88021
Assignees
@krish2718
Labels
bug The issue is a bug, or the PR is fixing a bug manifest-nrf_wifi priority: medium Medium impact/importance bug

Comments

@nordicjm
Copy link
Collaborator

nordicjm commented Apr 1, 2025

Describe the bug
This check here is completely invalid https://github.com/zephyrproject-rtos/zephyr/blob/main/modules/nrf_wifi/bus/CMakeLists.txt#L8 and needs removing

Expected behavior
No reliance upon variables that were deprecated 5+ years ago

Impact
Showstopper
@nordicjm nordicjm added the bug The issue is a bug, or the PR is fixing a bug label Apr 1, 2025
@nashif nashif added the priority: medium Medium impact/importance bug label Apr 1, 2025
krish2718 added a commit to krish2718/zephyr that referenced this issue Apr 2, 2025
@krish2718
modules: nrf_wifi: Remove unnecessary check
3058776 
The Zephyr base variable is not used below and also is deprecated and
not needed to be set.

Fixes zephyrproject-rtos#87950.

Signed-off-by: Chaitanya Tata <[email protected]>
@krish2718 krish2718 mentioned this issue Apr 2, 2025
Merged
@kartben kartben closed this as completed in 4875978 Apr 4, 2025
abrarnasirjaffari pushed a commit to abrarnasirjaffari/zephyr that referenced this issue Apr 9, 2025
@krish2718 @abrarnasirjaffari
modules: nrf_wifi: Remove unnecessary check
ed3c118 
The Zephyr base variable is not used below and also is deprecated and
not needed to be set.

Fixes zephyrproject-rtos#87950.

Signed-off-by: Chaitanya Tata <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krish2718 krish2718

Labels
bug The issue is a bug, or the PR is fixing a bug manifest-nrf_wifi priority: medium Medium impact/importance bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modules: nrf_wifi: Remove unnecessary check krish2718/zephyr
3 participants
@nashif @nordicjm @krish2718