-
Notifications
You must be signed in to change notification settings - Fork 7.3k
dts: stepper: unify msx-gpios #88066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Maybe more cases are needed to determine if this approach is worthwhile, so far, there seem to be only two. Over-abstracting can make things incomprehensible. WDYT? |
We have actually 3 stepper drivers which require this microstepping gpios. Two of them (allegro,ti) use I am personally in favour of msx-gpios since its concise and can be extended to both the use-cases requiring two/three gpios for setting microstepping resolution |
From what I have seen, having (two) gpio lines for microstep resolution is very common for stepper controller, and having astandard devicetree specification would make sense in that context. And using an array would make things more flexible for controllers who use a different number of pins for microstep resolution, through I don't know how widespread these are. |
I'd go with the |
Wouldn't the obvious placement be right next to the step-gpios and dir-gpios? 😅 |
Is your enhancement proposal related to a problem? Please describe.
At present bindings for micro-step-resolution-gpios is done in a different manner between different stepper drivers. For instance,
Describe the solution you'd like
Place msx-gpios in stepper-controller.yaml as a common binding and adjust the two stepper drivers that use m0-gpios and m1-gpios
Describe alternatives you've considered
It is either or between msx-gpios and m0/m1/m2-gpios.
msx-gpios is extensible and can be used for all the drivers that have 1-3 pins for setting micro-step-resolution.
Additional context
The text was updated successfully, but these errors were encountered: