drivers: stepper: unify msx-gpios #88798
Open
+87
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bjarki-andreasen,
decsny,
dipakgmx,
fabiobaltieri,
faxe1008,
galak,
jbehrensnx and
rruuaanng
dipakgmx
reviewed
Apr 18, 2025
jilaypandya
force-pushed
the
fix/msx-gpios
branch
from
b3d88eb to
177de4d
Compare
github-actions
bot
requested review from
MaureenHelm,
microbuilder,
ozersa,
ttmut and
yasinustunerg
jilaypandya
force-pushed
the
fix/msx-gpios
branch
from
177de4d to
26b2f12
Compare
currently there are two different ways how microstepping gpios are handled in step/dir drivers. This PR aims to unify the two different approaches. Signed-off-by: Jilay Pandya <[email protected]>
jilaypandya
force-pushed
the
fix/msx-gpios
branch
from
26b2f12 to
a056bb4
Compare
dipakgmx
approved these changes
Apr 18, 2025
faxe1008
reviewed
Apr 19, 2025
| #define STEP_DIR_STEPPER_DT_INST_COMMON_CONFIG_INIT(inst) \ | ||
| STEP_DIR_STEPPER_DT_COMMON_CONFIG_INIT(DT_DRV_INST(inst)) | ||
| #define STEP_DIR_STEPPER_DT_INST_COMMON_CONFIG_INIT(inst, msx_gpio_array) \ | ||
| STEP_DIR_STEPPER_DT_COMMON_CONFIG_INIT(DT_DRV_INST(inst), msx_gpio_array) |
There was a problem hiding this comment.
Why not read the property in here? Currently there is again potential for giving the property different names since the driver does the property checking.
There was a problem hiding this comment.
the *msx-pins cannot be scalar initialized here, or? The pointer has to be initialized to an already existing array.
| @@ -150,7 +152,7 @@ int step_dir_stepper_common_move_by(const struct device *dev, const int32_t micr | |||
| * @return 0 on success, or a negative error code on failure. | |||
| */ | |||
| int step_dir_stepper_common_set_microstep_interval(const struct device *dev, | |||
| const uint64_t microstep_interval_ns); | |||
| const uint64_t microstep_interval_ns); | |||
There was a problem hiding this comment.
Unrelated formatting :^)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently there are two different ways how microstepping gpios are handled in step/dir drivers. This PR aims to unify the two different approaches.
This resolves the issue: #88066