-
Notifications
You must be signed in to change notification settings - Fork 7.4k
soc: arm: nordic: provide custom busy_wait implementations #11627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
All checks are passing now. Review history of this comment for details about previous failed status. |
f898e57
to
7cfacc9
Compare
Codecov Report
@@ Coverage Diff @@
## master #11627 +/- ##
=========================================
Coverage ? 48.23%
=========================================
Files ? 279
Lines ? 43291
Branches ? 10359
=========================================
Hits ? 20881
Misses ? 18270
Partials ? 4140 Continue to review full report at Codecov.
|
Thanks for this PR! |
No; it comes from the soc subdirectory which isn't part of Zephyr. |
We should make it part of Zephyr then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The added z_arch_busy_wait
functions should call nrfx_coredep_delay_us
(once it is imported to Zephyr) instead of copying its content.
Implementation taken from Nordic nrfx version 1.3.1 soc/nrfx_coredep.h, modified to remove material from other series and to conform to Zephyr coding standards. Note that unlike standard k_busy_wait this is susceptible to longer-than-intended delays due to the impact of interrupt handling. Fixes zephyrproject-rtos#11626 Signed-off-by: Peter A. Bigot <[email protected]>
@anangl Requested modifications have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for providing this PR and fixing the issue!
Implementation taken from Nordic nrfx version 1.3.1 soc/nrfx_coredep.h,
modified to remove material from other series and to conform to Zephyr
coding standards.
Note that unlike standard k_busy_wait this is susceptible to
longer-than-intended delays due to the impact of interrupt handling.
Fixes #11626
Signed-off-by: Peter A. Bigot [email protected]