logging: add backend for xtensa simulator #14027
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
requested review from
andrewboie,
andyross,
nordic-krch and
rgundi
as code owners
nashif
force-pushed
the
xtensa_sim_log_backend
branch
from
299053f to
d1484da
Compare
Codecov Report
@@ Coverage Diff @@
## master #14027 +/- ##
=======================================
Coverage 52.24% 52.24%
=======================================
Files 307 307
Lines 45467 45467
Branches 10525 10525
=======================================
Hits 23752 23752
Misses 16913 16913
Partials 4802 4802Continue to review full report at Codecov.
|
jcmvbkbc
reviewed
Mar 4, 2019
| static int char_out(u8_t *data, size_t length, void *ctx) | ||
| { | ||
| for (size_t i = 0; i < length; i++) { | ||
| preprint_char(data[i]); |
There was a problem hiding this comment.
write simcall can output the whole buffer in one invocation
nashif
force-pushed
the
xtensa_sim_log_backend
branch
from
d1484da to
f50e69e
Compare
nordic-krch
approved these changes
Mar 4, 2019
| #include <logging/log_output.h> | ||
| #include <xtensa/simcall.h> | ||
|
|
||
| #define _STDOUT_BUF_SIZE 256 |
There was a problem hiding this comment.
if there a potential RAM shortages on xtensa boards this should be moved to kconfig.
Add backend for the xtensa simulator. Fixes zephyrproject-rtos#10164 Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
xtensa_sim_log_backend
branch
from
f50e69e to
f3802a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add backend for the xtensa simulator.
Fixes #10164