sanitycheck: order results.csv and discards.csv deterministically #15313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the first things needed when comparing builds of tests across different environments/systems is to make sure the same (sub)tests were selected and run in the first place. For that purpose sort the output of --testcase-report and --discard-report as they were in random order. Actually make the entire class TestInstance sortable by adding a standard __lt__() method comparing unique instance names; it could be useful again. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
added
area: Sanitycheck
nashif
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the first things needed when comparing builds of tests across
different environments/systems is to make sure the same (sub)tests were
selected and run in the first place. For that purpose sort the output of
--testcase-reportand--discard-reportas they were in random order.Actually make the entire class TestInstance sortable by adding a
standard
__lt__()method comparing unique instance names; it could beuseful again.
Signed-off-by: Marc Herbert [email protected]