Skip to content

lib: posix: auto allocate pthread stack if needed #16435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

lib: posix: auto allocate pthread stack if needed #16435

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed7a1bf
lib: posix: implement pthread_attr_setstacksize()
tgorochowik May 29, 2019
4ba6667
lib: posix: auto allocate pthread stack if needed
tgorochowik May 24, 2019
0add6ff
tests: posix: pthread: test auto stack allocation
tgorochowik May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/posix/common/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,6 @@ CONFIG_SEM_VALUE_MAX=32767
CONFIG_POSIX_MQUEUE=y
CONFIG_HEAP_MEM_POOL_SIZE=4096
CONFIG_MAX_THREAD_BYTES=4
CONFIG_MINIMAL_LIBC_MALLOC_ARENA_SIZE=4096

CONFIG_SMP=n
17 changes: 15 additions & 2 deletions tests/posix/common/src/pthread.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,23 @@

#define N_THR_E 3
#define N_THR_T 4
#define N_THR_T_AUTO_STACK 1
#define BOUNCES 64
#define STACKS (1024 + CONFIG_TEST_EXTRA_STACKSIZE)
#define THREAD_PRIORITY 3
#define ONE_SECOND 1

#if CONFIG_MINIMAL_LIBC_MALLOC_ARENA_SIZE < STACKS * N_THR_T_AUTO_STACK
#error "Insufficient malloc arena size"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to hit for 119 tests or so... ;-).

#endif

/* Macros to test invalid states */
#define PTHREAD_CANCEL_INVALID -1
#define SCHED_INVALID -1
#define PRIO_INVALID -1

K_THREAD_STACK_ARRAY_DEFINE(stack_e, N_THR_E, STACKS);
K_THREAD_STACK_ARRAY_DEFINE(stack_t, N_THR_T, STACKS);
K_THREAD_STACK_ARRAY_DEFINE(stack_t, N_THR_T - N_THR_T_AUTO_STACK, STACKS);

void *thread_top_exec(void *p1);
void *thread_top_term(void *p1);
Expand Down Expand Up @@ -386,7 +391,15 @@ void test_posix_pthread_termination(void)

schedparam.sched_priority = 2;
pthread_attr_setschedparam(&attr[i], &schedparam);
pthread_attr_setstack(&attr[i], &stack_t[i][0], STACKS);

if (i < N_THR_T - N_THR_T_AUTO_STACK) {
pthread_attr_setstack(&attr[i],
&stack_t[i][0],
STACKS);
} else {
pthread_attr_setstacksize(&attr[i], STACKS);
}

ret = pthread_create(&newthread[i], &attr[i], thread_top_term,
(void *)i);

Expand Down