net: getaddrinfo: Query both IPv4 and IPv6 if hints is missing

[jukkar]

We must query both IPv4 and IPv6 addresses if the hints parameter
is NULL i.e., user does not supply hints.

Fixes #16453

Signed-off-by: Jukka Rissanen [email protected]

[pfalcon]

net: getaddrinfo: Query both IPv4 and IPv6 if hints is missing

Nitpick about commit message: fairly speaking, the matter should be that IPv4 and IPv6 should be both queried if hints has AF_UNSPEC address family (and that's default if hints is NULL at all).

[pfalcon]

Thanks for picking this up. To avoid future confusion when working with this func, would be nice to add one, better both, of: a) code comments; b) testcase for this behavior.

As you know, I never insist on b), though that's a perfect example where we need this... (Again, not insisting.)

[jukkar]

Updated according to comments.

[pfalcon]

Thanks for the updates, looks great!

Removing platform_whitelist was a bit too brave and hits the same issue patch from @andrewboie hit earlier. Better to skip that change for now I guess.

[jukkar]

Removing platform_whitelist was a bit too brave and hits the same issue patch from @andrewboie hit earlier. Better to skip that change for now I guess.

I have been removing the whitelists in various PRs. Created an issue yesterday for this one #16778

[jukkar]

Rebased against latest master.

[pfalcon]

As this no longer contains any changes not described in the topic of the PR, I'd suggest to merge it. (I guess @tbursztyka is on vacation, nor this is his known area of interest.)

[jukkar]

recheck

[backporting]

The backport to v1.14-branch failed:

Commits ["cb52096f2cda2f9b69c73f4c5efab0aa1a30efe8","ee8e8abe4e05ae0aeab10c43705f41970be31172"] could not be cherry-picked on top of v1.14-branch

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport v1.14-branch
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick cb52096f2cda2f9b69c73f4c5efab0aa1a30efe8 ee8e8abe4e05ae0aeab10c43705f41970be31172
# Create a new branch with these backported commits.
git checkout -b backport-16772-to-v1.14-branch
# Push it to GitHub.
git push --set-upstream origin backport-16772-to-v1.14-branch
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is v1.14-branch and the compare/head branch is backport-16772-to-v1.14-branch.