BOOT_BANNER: show KERNEL_VERSION and BUILD_VERSION differently #16917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-hb
added
area: Build System
Enhancement
carlescufi
approved these changes
Jun 19, 2019
jukkar
approved these changes
Jun 19, 2019
nashif
requested changes
Jun 19, 2019
kernel/init.c
Outdated
| @@ -50,10 +50,10 @@ LOG_MODULE_REGISTER(os); | |||
| #endif | |||
|
|
|||
| #ifdef BUILD_VERSION | |||
| #define BOOT_BANNER "Booting Zephyr OS " \ | |||
| #define BOOT_BANNER "Booting Zephyr build " \ | |||
There was a problem hiding this comment.
Booting Zephyr OS - Build/Version <blah>
Zephyr has two unrelated build _VERSIONs: KERNEL_VERSION and BUILD_VERSION. Prefix them slightly differently in BOOT_BANNER so anyone can instantly zoom in on which one is being used without having to compare the implementation details of both. Signed-off-by: Marc Herbert <[email protected]>
marc-hb
force-pushed
the
show-different-zephyr-versions
branch
from
5a97627 to
ee8c08d
Compare
nashif
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zephyr has to unrelated build _VERSIONs: KERNEL_VERSION and
BUILD_VERSION. Prefix them slightly differently in BOOT_BANNER so anyone
can instantly zoom in on which one is being used without having to
compare the implementation details of both.
Signed-off-by: Marc Herbert [email protected]