Open amp refactoring and add more platforms support #17553

karl-zh · 2019-07-16T03:26:20Z

openAMP is a multiple core IPC which supported in Zephyr. This PR is going to make it supported for more multiple core platforms rather than for lpc54 only.

Currently added the arm platform AN521 and Musca A, for further plan is to supporting Musca B1 when #16729 get merged.

zephyrbot · 2019-07-16T03:32:52Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

galak · 2019-07-16T15:39:53Z

@arnop2 can you take a look at this PR. I'm not that familiar with how we should be conveying the shared memory region in DTS.

boards/arm/mps2_an521/mps2_an521_nonsecure.dts

boards/arm/mps2_an521/mps2_an521.dts

dbkinder

one doc question, otherwise looks good.

samples/subsys/ipc/openamp/README.rst

soc/arm/nxp_lpc/lpc54xxx/dts_fixup.h

boards/arm/mps2_an521/mps2_an521_nonsecure.overlay

samples/subsys/ipc/openamp/sse_200.conf

soc/arm/arm/mps2/dts_fixup.h

dbkinder

+1 for doc changes, thanks.

arnopo

Just 2 minor remarks remaining, then should be ok for me

samples/subsys/ipc/openamp/common.h

samples/subsys/ipc/openamp/CMakeLists.txt

scripts/dts/extract/globals.py

galak · 2019-09-19T18:20:41Z

samples/subsys/ipc/openamp/remote/src/main.c

+	defined(CONFIG_SOC_V2M_MUSCA_B1)
+	u32_t current_core = sse_200_platform_get_cpu_id();
+
+	ipm_send(ipm_handle, 0, current_core ? 0 : 1, 0, 1);


Why does the data here mater?

The dummy data is not necessary here for MHU based hardware. But it needs to distinguish the current core No. for notifications.

galak · 2019-09-21T14:10:09Z

Ok, I tried this on musca-a1 and qemu-mps2_an521 and it doesn't seem to work. Also tried the samples/subsys/ipc/ipm_mhu_dual_core on those platforms and they didn't seem to pass. Something to debug this week.

karl-zh · 2019-09-21T16:45:54Z

Ok, I tried this on musca-a1 and qemu-mps2_an521 and it doesn't seem to work. Also tried the samples/subsys/ipc/ipm_mhu_dual_core on those platforms and they didn't seem to pass. Something to debug this week.

Okay, I also need some refresh of memory to this context. Maybe some rebase conflicts or other changes need rebase. BTW, do you have some fail details? I just have a test pass on my side with the previous commit I had on AN521, here is the command line for you reference:

AN521:
~/zephyr/samples/subsys/ipc/openamp/build$ cmake -GNinja -DBOARD=mps2_an521 -DCONF_FILE=prj.conf ..; ninja -v; cp ./openamp_remote-prefix/src/openamp_remote-build/zephyr/zephyr.bin ../zephyr_ns.bin ; cp zephyr/zephyr.bin ../zephyr.bin

Config file:
TITLE: Versatile Express Images Configuration File

[IMAGES]
TOTALIMAGES: 2 ;Number of Images (Max: 32)

IMAGE0ADDRESS: 0x10000000 ;Please select the required executable program
IMAGE0FILE: \SW\zephyr.bin ; - selftest

IMAGE1ADDRESS: 0x100000
IMAGE1FILE: \SW\zephyr_ns.bin

galak · 2019-09-21T16:52:05Z

Okay, I also need some refresh of memory to this context. Maybe some rebase conflicts or other changes need rebase. BTW, do you have some fail details? I just have a test pass on my side with the previous commit I had on AN521, here is the command line for you reference:

AN521:
~/zephyr/samples/subsys/ipc/openamp/build$ cmake -GNinja -DBOARD=mps2_an521 -DCONF_FILE=prj.conf ..; ninja -v; cp ./openamp_remote-prefix/src/openamp_remote-build/zephyr/zephyr.bin ../zephyr_ns.bin ; cp zephyr/zephyr.bin ../zephyr.bin

Config file:
TITLE: Versatile Express Images Configuration File

[IMAGES]
TOTALIMAGES: 2 ;Number of Images (Max: 32)

IMAGE0ADDRESS: 0x10000000 ;Please select the required executable program
IMAGE0FILE: \SW\zephyr.bin ; - selftest

IMAGE1ADDRESS: 0x100000
IMAGE1FILE: \SW\zephyr_ns.bin

Hmm, need to parse this in more detail. However is it possible to run the test w/o SECURE/NON-SECURE?

karl-zh · 2019-09-21T16:58:54Z

Okay, I also need some refresh of memory to this context. Maybe some rebase conflicts or other changes need rebase. BTW, do you have some fail details? I just have a test pass on my side with the previous commit I had on AN521, here is the command line for you reference:
AN521:
~/zephyr/samples/subsys/ipc/openamp/build$ cmake -GNinja -DBOARD=mps2_an521 -DCONF_FILE=prj.conf ..; ninja -v; cp ./openamp_remote-prefix/src/openamp_remote-build/zephyr/zephyr.bin ../zephyr_ns.bin ; cp zephyr/zephyr.bin ../zephyr.bin
Config file:
TITLE: Versatile Express Images Configuration File
[IMAGES]
TOTALIMAGES: 2 ;Number of Images (Max: 32)
IMAGE0ADDRESS: 0x10000000 ;Please select the required executable program
IMAGE0FILE: \SW\zephyr.bin ; - selftest
IMAGE1ADDRESS: 0x100000
IMAGE1FILE: \SW\zephyr_ns.bin

Hmm, need to parse this in more detail. However is it possible to run the test w/o SECURE/NON-SECURE?

I might using a wrong binary name here. They are following the start work for tfm integrating with Zpehyr.
The two binaries here are for different CPUs, \SW\zephyr.bin is for CPU0 and \SW\zephyr_ns.bin is for CPU1, the name is for configurations file only(images.txt).

jhedberg · 2020-01-07T15:09:20Z

This PR seems to require rebasing since there are conflicts. Is something still missing before it can be merged (e.g. approvals or some additional code changes)?

karl-zh · 2020-01-08T01:01:39Z

This PR seems to require rebasing since there are conflicts. Is something still missing before it can be merged (e.g. approvals or some additional code changes)?

Hi Johan

I think this PR needs approval before the merge.

jhedberg · 2020-01-14T15:16:26Z

I think this PR needs approval before the merge.

@karl-zh while waiting for approval, could you rebase and fix the conflict with samples/subsys/ipc/openamp/sample.yaml?

karl-zh · 2020-01-19T04:55:48Z

I think this PR needs approval before the merge.

@karl-zh while waiting for approval, could you rebase and fix the conflict with samples/subsys/ipc/openamp/sample.yaml?

Hi
I was trying to resolve the conflict from github, but it seems CI fail. I am on leave for the Chinese New Year holiday recently and will rebase/resolve and try to make CI pass when back to the office.
The approval and review is required too.

Thanks for your comments.

erwango · 2020-01-20T08:49:51Z

@karl-zh, was this intentional to push a merge commit ?

zephyrbot · 2020-03-26T09:58:10Z

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Move board specific conf info boards/<BOARD>.conf to support other board/SoCs with this sample. Signed-off-by: Kumar Gala <[email protected]>

Add configuable shared memory address for openAMP samples. There is a plan to add more platforms supported for openAMP in zephyr. Each platform can specify the shared memory address and device by device tree and add it's support in openAMP samples. Signed-off-by: Karl Zhang <[email protected]> Signed-off-by: Kumar Gala <[email protected]>

Update serial output for both master and remote. Signed-off-by: Karl Zhang <[email protected]>

Set sse-200 subsystem using MHU (Message Handling Unit) as default. Signed-off-by: Karl Zhang <[email protected]>

AN521 is a dual core FPGA on MPS2+ with both cores are CM33. Add openAMP to support on it. Core 0 is primary core, it runs as master, core 1 is remote, it runs as slave. Signed-off-by: Karl Zhang <[email protected]>

Musca A is a dual core SoC with both cores are CM33. Add openAMP to support on it. Signed-off-by: Karl Zhang <[email protected]>

Musca B1 is a dual core SoC with both cores are CM33. Add openAMP to support on it. Signed-off-by: Karl Zhang <[email protected]>

karl-zh requested review from dbkinder, fvincenzo, galak, ioannisg, MaureenHelm and nashif as code owners July 16, 2019 03:26

zephyrbot added area: Devicetree area: Boards area: Samples Samples labels Jul 16, 2019

karl-zh force-pushed the openAMP_refactoring branch 3 times, most recently from dea2528 to 079407e Compare July 16, 2019 06:48

galak requested a review from arnopo July 16, 2019 15:38

galak added the area: IPC Inter-Process Communication label Jul 16, 2019

arnopo reviewed Jul 16, 2019

View reviewed changes

boards/arm/mps2_an521/mps2_an521_nonsecure.dts Outdated Show resolved Hide resolved

boards/arm/mps2_an521/mps2_an521.dts Outdated Show resolved Hide resolved

dbkinder suggested changes Jul 16, 2019

View reviewed changes

samples/subsys/ipc/openamp/README.rst Outdated Show resolved Hide resolved

karl-zh force-pushed the openAMP_refactoring branch from 079407e to 3149819 Compare July 23, 2019 13:58

karl-zh requested review from dbkinder and arnopo July 24, 2019 02:51

arnopo requested changes Jul 24, 2019

View reviewed changes

dbkinder approved these changes Jul 24, 2019

View reviewed changes

karl-zh force-pushed the openAMP_refactoring branch 3 times, most recently from d92786d to d9d3241 Compare July 26, 2019 12:15

karl-zh requested a review from arnopo July 27, 2019 14:05

arnopo requested changes Jul 29, 2019

View reviewed changes

samples/subsys/ipc/openamp/common.h Show resolved Hide resolved

samples/subsys/ipc/openamp/CMakeLists.txt Outdated Show resolved Hide resolved

karl-zh force-pushed the openAMP_refactoring branch from d9d3241 to 3c12b92 Compare July 29, 2019 13:40

erwango reviewed Jul 29, 2019

View reviewed changes

scripts/dts/extract/globals.py Outdated Show resolved Hide resolved

galak force-pushed the openAMP_refactoring branch from c65ba22 to a5254ca Compare September 19, 2019 18:18

galak reviewed Sep 19, 2019

View reviewed changes

arnopo mentioned this pull request Nov 14, 2019

nRF53: HCI driver & sample #20467

Merged

galak force-pushed the openAMP_refactoring branch from a5254ca to c74049b Compare November 14, 2019 14:15

arnopo mentioned this pull request Nov 15, 2019

OpenAMP as service for multiple users #20419

Closed

karl-zh force-pushed the openAMP_refactoring branch from da83b2a to 8162050 Compare February 20, 2020 02:38

galak force-pushed the openAMP_refactoring branch 2 times, most recently from 480a371 to ce90b7e Compare March 26, 2020 09:55

galak approved these changes Mar 26, 2020

View reviewed changes

galak and others added 7 commits March 26, 2020 05:12

samples: openamp: prep for additional board support

02d7d7e

Move board specific conf info boards/<BOARD>.conf to support other board/SoCs with this sample. Signed-off-by: Kumar Gala <[email protected]>

samples: openamp: Keep document up to date

a1cc218

Update serial output for both master and remote. Signed-off-by: Karl Zhang <[email protected]>

IPM: Add MHU as default IPM for sse-200 subsystem

8b10213

Set sse-200 subsystem using MHU (Message Handling Unit) as default. Signed-off-by: Karl Zhang <[email protected]>

samples: openamp: Add support for mps2_an521

688043d

AN521 is a dual core FPGA on MPS2+ with both cores are CM33. Add openAMP to support on it. Core 0 is primary core, it runs as master, core 1 is remote, it runs as slave. Signed-off-by: Karl Zhang <[email protected]>

samples: openamp: Add support for Musca A

9be33b7

Musca A is a dual core SoC with both cores are CM33. Add openAMP to support on it. Signed-off-by: Karl Zhang <[email protected]>

samples: openamp: Add support for Musca B1

a21437f

Musca B1 is a dual core SoC with both cores are CM33. Add openAMP to support on it. Signed-off-by: Karl Zhang <[email protected]>

galak force-pushed the openAMP_refactoring branch from ce90b7e to a21437f Compare March 26, 2020 10:12

This was referenced Mar 26, 2020

OpenAMP rsc table sample #16985

Merged

lib: update libmetal to release v2020.01.0 zephyrproject-rtos/libmetal#1

Merged

galak merged commit fbd8cff into zephyrproject-rtos:master Mar 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Open amp refactoring and add more platforms support #17553

Open amp refactoring and add more platforms support #17553

karl-zh commented Jul 16, 2019

zephyrbot commented Jul 16, 2019 •

edited

Loading

galak commented Jul 16, 2019

dbkinder left a comment

dbkinder left a comment

arnopo left a comment

galak Sep 19, 2019

karl-zh Sep 21, 2019

galak commented Sep 21, 2019

karl-zh commented Sep 21, 2019 •

edited

Loading

galak commented Sep 21, 2019

karl-zh commented Sep 21, 2019

jhedberg commented Jan 7, 2020

karl-zh commented Jan 8, 2020

jhedberg commented Jan 14, 2020

karl-zh commented Jan 19, 2020

erwango commented Jan 20, 2020

zephyrbot commented Mar 26, 2020 •

edited

Loading

Open amp refactoring and add more platforms support #17553

Open amp refactoring and add more platforms support #17553

Conversation

karl-zh commented Jul 16, 2019

zephyrbot commented Jul 16, 2019 • edited Loading

galak commented Jul 16, 2019

dbkinder left a comment

Choose a reason for hiding this comment

dbkinder left a comment

Choose a reason for hiding this comment

arnopo left a comment

Choose a reason for hiding this comment

galak Sep 19, 2019

Choose a reason for hiding this comment

karl-zh Sep 21, 2019

Choose a reason for hiding this comment

galak commented Sep 21, 2019

karl-zh commented Sep 21, 2019 • edited Loading

galak commented Sep 21, 2019

karl-zh commented Sep 21, 2019

jhedberg commented Jan 7, 2020

karl-zh commented Jan 8, 2020

jhedberg commented Jan 14, 2020

karl-zh commented Jan 19, 2020

erwango commented Jan 20, 2020

zephyrbot commented Mar 26, 2020 • edited Loading

zephyrbot commented Jul 16, 2019 •

edited

Loading

karl-zh commented Sep 21, 2019 •

edited

Loading

zephyrbot commented Mar 26, 2020 •

edited

Loading