Add support for STM32L432KC and Nucleo L432KC board #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

galak merged 4 commits into zephyrproject-rtos:arm from superna9999:stm32l432_nucleo

May 8, 2017

Collaborator

superna9999 commented Apr 29, 2017 •

edited by galak

Loading

The STM32L4x2 SoC serie is a lowered down version of the STM32L4x6 SoCs.

This PR adds support for the STM32L432KC SoC and support for the Nucleo L432KC from the Nucleo-32 boards serie.
Documentation for the Nucleo L432KC is added based on the Nucleo L476RG format.

This change is

superna9999 force-pushed the stm32l432_nucleo branch from d3d75e6 to 237dc4f Compare

April 29, 2017 20:06

nashif requested a review from dbkinder

April 29, 2017 20:46

galak self-assigned this

dbkinder reviewed

View reviewed changes

boards/arm/nucleo_l432kc/doc/nucleol432kc.rst Outdated

    
              - Ultra-low-power with FlexPowerControl (down to 28 nA Standby mode and 84 μA/MHz run mode)

              - Core: ARM® 32-bit Cortex®-M4 CPU with FPU, frequency up to 80 MHz, 100DMIPS/1.25DMIPS/MHz (Dhrystone 2.1)

              - Clock Sources:

                      - 32 kHz crystal oscillator for RTC (LSE)

Contributor

dbkinder Apr 29, 2017

Lists (and sub-lists) need a blank line before and after the lists, so add a blank line before - 32 kHz

Collaborator Author

superna9999 Apr 30, 2017

Ok

dbkinder reviewed

View reviewed changes

boards/arm/nucleo_l432kc/doc/nucleol432kc.rst Outdated

    
                      - Internal low-power 32 kHz RC (±5%)

                      - Internal multispeed 100 kHz to 48 MHz oscillator, auto-trimmed by LSE (better than ±0.25 % accuracy)

                      - 2 PLLs for system clock, USB, audio, ADC

              - RTC with HW calendar, alarms and calibration

Contributor

dbkinder Apr 29, 2017

add a blank like after the (sub)list ends and before - RTC

Collaborator Author

superna9999 Apr 30, 2017

Ok

dbkinder reviewed

View reviewed changes

boards/arm/nucleo_l432kc/doc/nucleol432kc.rst Outdated

    
              - RTC with HW calendar, alarms and calibration

              - Up to 3 capacitive sensing channels: support touchkey, linear and rotary touch sensors

              - 11x timers:

                      - 1x 16-bit advanced motor-control

Contributor

dbkinder Apr 29, 2017

add a blank line before this sublist

Collaborator Author

superna9999 Apr 30, 2017

Ok

dbkinder reviewed

View reviewed changes

boards/arm/nucleo_l432kc/doc/nucleol432kc.rst Outdated

    
                      - 2x low-power 16-bit timers (available in Stop mode)

                      - 2x watchdogs

                      - SysTick timer

              - Up to 26 fast I/Os, most 5 V-tolerant

Contributor

dbkinder Apr 29, 2017

... and a blank line after the sublist

Collaborator Author

superna9999 Apr 30, 2017

Ok

dbkinder reviewed

View reviewed changes

boards/arm/nucleo_l432kc/doc/nucleol432kc.rst Outdated

    
                      - SysTick timer

              - Up to 26 fast I/Os, most 5 V-tolerant

              - Memories

                      - Up to 256 KB single bank Flash, proprietary code readout protection

Contributor

dbkinder Apr 29, 2017

Add blank line before and after the sublist... same for the sublists below

Collaborator Author

superna9999 Apr 30, 2017

Ok

dbkinder reviewed

View reviewed changes

boards/arm/nucleo_l432kc/doc/nucleol432kc.rst Outdated

    
                      - 2x SPIs (3x SPIs with the Quad SPI)

                      - CAN (2.0B Active)

                      - SWPMI single wire protocol master I/F

              	- IRTIM (Infrared interface)

Contributor

dbkinder Apr 30, 2017

indent needs to match previous line

Collaborator Author

superna9999 Apr 30, 2017

Ok

dbkinder reviewed

View reviewed changes

boards/arm/nucleo_l432kc/doc/nucleol432kc.rst Outdated

    
              - Arduino Uno V3 connectivity

              - On-board ST-LINK/V2-1 debugger/programmer with SWD connector

              - Flexible board power supply:

                     - USB VBUS or external source(3.3V, 5V, 7 - 12V)

Contributor

dbkinder Apr 30, 2017

sublists should have a blank like before and after htem

Collaborator Author

superna9999 Apr 30, 2017

Ok

dbkinder suggested changes

View reviewed changes

Contributor

dbkinder left a comment

A few formatting tweaks, otherwise looks OK

superna9999 force-pushed the stm32l432_nucleo branch from 237dc4f to 3f293d2 Compare

April 30, 2017 11:14

dbkinder reviewed

View reviewed changes

Contributor

dbkinder left a comment

+1

erwango reviewed

View reviewed changes

dts/arm/nucleo_l432kc.fixup Outdated

    
              #define CONFIG_NUM_IRQ_PRIO_BITS	ARM_V7M_NVIC_E000E100_ARM_NUM_IRQ_PRIORITY_BITS

              #define CONFIG_UART_STM32_PORT_1_BASE_ADDRESS	ST_STM32_USART_40013800_BASE_ADDRESS

              #define CONFIG_UART_STM32_PORT_1_BAUD_RATE	ST_STM32_USART_40013800_BAUD_RATE

Member

erwango May 2, 2017

Rename ST_STM32_USART_40013800_BAUD_RATE as ST_STM32_USART_40013800_CURRENT_SPEED

Collaborator Author

superna9999 May 2, 2017

Ok

dts/arm/nucleo_l432kc.fixup Outdated

    
              #define PORT_1_IRQ				ST_STM32_USART_40013800_IRQ_0

              #define CONFIG_UART_STM32_PORT_2_BASE_ADDRESS	ST_STM32_USART_40004400_BASE_ADDRESS

              #define CONFIG_UART_STM32_PORT_2_BAUD_RATE	ST_STM32_USART_40004400_BAUD_RATE

Member

erwango May 2, 2017

same here

dts/arm/nucleo_l432kc.fixup Outdated

    
              #define PORT_2_IRQ				ST_STM32_USART_40004400_IRQ_0

              #define CONFIG_UART_STM32_PORT_3_BASE_ADDRESS	ST_STM32_USART_40004800_BASE_ADDRESS

              #define CONFIG_UART_STM32_PORT_3_BAUD_RATE	ST_STM32_USART_40004800_BAUD_RATE

Member

erwango May 2, 2017

same here

dts/arm/nucleo_l432kc.fixup Outdated

    
              #define PORT_3_IRQ				ST_STM32_USART_40004800_IRQ_0

              #define CONFIG_UART_STM32_PORT_4_BASE_ADDRESS	ST_STM32_USART_40004C00_BASE_ADDRESS

              #define CONFIG_UART_STM32_PORT_4_BAUD_RATE	ST_STM32_USART_40004C00_BAUD_RATE

Member

erwango May 2, 2017

same here

erwango approved these changes

View reviewed changes

erwango requested changes

View reviewed changes

Member

erwango left a comment

Sorry previous comment. I only ment to +1 only first commit.
Removing the "approved on all changes"

superna9999 force-pushed the stm32l432_nucleo branch from 3f293d2 to 38d12c3 Compare

May 2, 2017 09:24

galak requested changes

View reviewed changes

Collaborator

galak left a comment

The SoC and Board bits should be split, so that the board.dts, dts/arm/Makefile, fixup, are part of the patch that adds the board to Zephyr.

superna9999 force-pushed the stm32l432_nucleo branch 2 times, most recently from ef77407 to 2dfc637 Compare

May 3, 2017 07:51

Collaborator Author

superna9999 commented May 3, 2017

@galak it seems the shippable script throws me errors on commits not part of this PR

superna9999 force-pushed the stm32l432_nucleo branch from 2dfc637 to abc039f Compare

May 3, 2017 13:27

pfalcon mentioned this pull request

Closed

galak force-pushed the arm branch 2 times, most recently from 78c0221 to a1c74b7 Compare

May 4, 2017 14:02

galak requested changes

View reviewed changes

Collaborator

galak left a comment

So the patch sequence seems out of order here:
The board patch should be last. I'd expect:

pinmux: stm32: Do not compile PORTD when not available
arm: stm32l4: Add configuration for STM32L432XX
(merge dts: Add support for STM32L432)
pinmux: stm32: Add support for Nucleo L432KC
boards: arm: Add Nucleo L432KC (merge dts: Add support for Nucleo L432KC)


          pinmux: stm32: Do not compile PORTD when not available

3106ca4

The STM32L432 does not have a PORTD gpio, disable it when not available.

Signed-off-by: Neil Armstrong <[email protected]>

superna9999 force-pushed the stm32l432_nucleo branch from abc039f to 961ada0 Compare

May 5, 2017 08:34

superna9999 added 2 commits

May 5, 2017 08:36


          arm: stm32l4: Add configuration and dts for STM32L432XX

7f2fff1

Add configuration and dts for the STM32L432XX SoC STM32L4 variant.

Signed-off-by: Neil Armstrong <[email protected]>


          pinmux: stm32: Add support for Nucleo L432KC

b0de4a3

Add pinmux configuration for the Nucleo L432KC board

Signed-off-by: Neil Armstrong <[email protected]>

superna9999 force-pushed the stm32l432_nucleo branch from 961ada0 to 1f9bafd Compare

May 5, 2017 08:37

Collaborator Author

superna9999 commented May 5, 2017

Hmm, when pushing partial rebase, the order showed in the PR is wrong..

On the original branch (https://github.com/superna9999/zephyr/commits/stm32l432_nucleo) , the commits are:
1f9bafd boards: arm: Add support for Nucleo L432KC
b0de4a3 pinmux: stm32: Add support for Nucleo L432KC
7f2fff1 arm: stm32l4: Add configuration and dts for STM32L432XX
3106ca4 pinmux: stm32: Do not compile PORTD when not available

But the shippable status is on the good commit.


          boards: arm: Add support for Nucleo L432KC

Add configuration, dts and documentation for the Nucleo L432KC board
based on the STM32L432KC SoC.

Signed-off-by: Neil Armstrong <[email protected]>

superna9999 force-pushed the stm32l432_nucleo branch from 1f9bafd to 5675509 Compare

May 5, 2017 14:24

galak approved these changes

View reviewed changes

Collaborator

galak left a comment

Looks, good - let me see about dbkinder adding his approval

dbkinder approved these changes

View reviewed changes

Contributor

dbkinder left a comment

I guess just leaving a +1 comment doesn't work, so I'll pick the Approve button this time 👍

galak merged commit 2187c1c into zephyrproject-rtos:arm

mike-scott pushed a commit to mike-scott/zephyr that referenced this pull request


          Merge pull request zephyrproject-rtos#19 from mbolivar/master-upstrea…

7c71684

…m-dev-17.05

Master upstream dev 17.05

frasa pushed a commit to blik-GmbH/zephyr that referenced this pull request


          Merge branch 'feat-ci' into 'dev'

3efe518

feat: ci: add gitlint and stylecheck

Closes zephyrproject-rtos#19, zephyrproject-rtos#22, and zephyrproject-rtos#23

See merge request blik/embedded/zephyr!26

xiaoliang314 mentioned this pull request

Bluetooth: Mesh: Rx buffer exhaustion causes deadlock #16864

Closed

xiaoliang314 mentioned this pull request

Bluetooth: Fix various deadlock issues when running low on buffers #16870

Closed

carlescufi mentioned this pull request

doc: Bluetooth: Document issue with certain controllers #24688

Merged

carlescufi added a commit to carlescufi/zephyr that referenced this pull request


          doc: Bluetooth: Document issue with certain controllers

f225f19

Certain Qualcomm controllers do not accept our settings for Host Buffer
Size:

< HCI Command: Host Buffer Size (0x03|0x0033) plen 7       zephyrproject-rtos#19 [hci0]
22.391048
        ACL MTU: 27   ACL max packet: 6
        SCO MTU: 0    SCO max packet: 0
> HCI Event: Command Complete (0x0e) plen 4                zephyrproject-rtos#20 [hci0]
22.391525
      Host Buffer Size (0x03|0x0033) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Likely due to the fact that we do not reserve space for any SCO packets
in the Host.

Other Controllers (Realtek) seem to not transmit any data at all in the
Controller to Host direction if Controller to Host flow control is
enabled.

Document this fact in the User Guide so that users know what to do when
this happens.

Signed-off-by: Carles Cufi <[email protected]>

jhedberg pushed a commit that referenced this pull request


          doc: Bluetooth: Document issue with certain controllers

3d16bda

Certain Qualcomm controllers do not accept our settings for Host Buffer
Size:

< HCI Command: Host Buffer Size (0x03|0x0033) plen 7       #19 [hci0]
22.391048
        ACL MTU: 27   ACL max packet: 6
        SCO MTU: 0    SCO max packet: 0
> HCI Event: Command Complete (0x0e) plen 4                #20 [hci0]
22.391525
      Host Buffer Size (0x03|0x0033) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Likely due to the fact that we do not reserve space for any SCO packets
in the Host.

Other Controllers (Realtek) seem to not transmit any data at all in the
Controller to Host direction if Controller to Host flow control is
enabled.

Document this fact in the User Guide so that users know what to do when
this happens.

Signed-off-by: Carles Cufi <[email protected]>

hakehuang referenced this pull request in hakehuang/zephyr


          doc: Bluetooth: Document issue with certain controllers

c68f5d4

Certain Qualcomm controllers do not accept our settings for Host Buffer
Size:

< HCI Command: Host Buffer Size (0x03|0x0033) plen 7       #19 [hci0]
22.391048
        ACL MTU: 27   ACL max packet: 6
        SCO MTU: 0    SCO max packet: 0
> HCI Event: Command Complete (0x0e) plen 4                #20 [hci0]
22.391525
      Host Buffer Size (0x03|0x0033) ncmd 1
        Status: Invalid HCI Command Parameters (0x12)

Likely due to the fact that we do not reserve space for any SCO packets
in the Host.

Other Controllers (Realtek) seem to not transmit any data at all in the
Controller to Host direction if Controller to Host flow control is
enabled.

Document this fact in the User Guide so that users know what to do when
this happens.

Signed-off-by: Carles Cufi <[email protected]>

anchao mentioned this pull request

Bluetooth: Mesh: Fix tx seg buffer with NULL pointer reference #27251

Merged

RafaelLeeImg mentioned this pull request

Kernel usage fault when using semaphore with multi-threading #41963

Closed

piotrParf mentioned this pull request

BLE Testing functions do not work properly #42534

Closed

sjanc mentioned this pull request

Assert when executing GATT/SR/GAW/BV-14-C test #57930

Closed

RadekPolyend mentioned this pull request

drivers: usb: udc: udc_mcux_ehci: UDC_MCUX_EHCI tries to acquire mutex within the ISR #85070

Closed

FlorianWeber1018 mentioned this pull request

drivers: usb: device: raspberrypi_pico_usbd - use of uninitialized semaphore #83806

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet