Skip to content

sanitycheck: deal with board that have no DTS #20365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

nashif
Copy link
Member

@nashif nashif commented Nov 5, 2019

nrf52_bsim does not generate any DTS data to be processed by
sanitycheck, skip filtering if we have no dts data.

nrf52_bsim does not generate any DTS data to be processed by
sanitycheck, skip filtering if we have no dts data.

Signed-off-by: Anas Nashif <[email protected]>
@nashif nashif requested a review from galak November 5, 2019 23:46
@nashif nashif added the Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc. label Nov 5, 2019
@nashif
Copy link
Member Author

nashif commented Nov 5, 2019

This is now blocking CI and was not detected earlier because of exceptions in sanitycheck were ignored.

@nashif nashif requested a review from andrewboie November 5, 2019 23:49
@zephyrbot zephyrbot added the area: Sanitycheck Sanitycheck has been renamed to Twister label Nov 5, 2019
@nashif nashif merged commit 556f3cb into zephyrproject-rtos:master Nov 6, 2019
@nashif nashif deleted the no_dts branch November 6, 2019 00:39
aescolar added a commit to aescolar/zephyr that referenced this pull request Nov 6, 2019
PR zephyrproject-rtos#20204 broke master for boards without DTS
PR zephyrproject-rtos#20365 tried to partially fix it, but the filtering in
sanitycheck remained broken
Let's quickly revert it to allow other PRs to come in,
and then resubmit them in a separate PR.

This reverts commit 556f3cb.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar added a commit to aescolar/zephyr that referenced this pull request Nov 6, 2019
PR zephyrproject-rtos#20204 broke master for boards without DTS
PR zephyrproject-rtos#20365 tried to partially fix it, but the filtering in
sanitycheck remained broken
Let's quickly revert it to allow other PRs to come in,
and then resubmit them in a separate PR.

This reverts commit 4cc91fd.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar added a commit to aescolar/zephyr that referenced this pull request Nov 6, 2019
PR zephyrproject-rtos#20204 broke master for boards without DTS
PR zephyrproject-rtos#20365 tried to partially fix it, but the filtering in
sanitycheck remained broken
Let's quickly revert it to allow other PRs to come in,
and then resubmit them in a separate PR.

This reverts commit 9b5720d.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar added a commit to aescolar/zephyr that referenced this pull request Nov 6, 2019
PR zephyrproject-rtos#20204 broke master for boards without DTS
PR zephyrproject-rtos#20365 tried to partially fix it, but the filtering in
sanitycheck remained broken
Let's quickly revert it to allow other PRs to come in,
and then resubmit them in a separate PR.

This reverts commit 7733b94.

Signed-off-by: Alberto Escolar Piedras <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Sanitycheck Sanitycheck has been renamed to Twister Hotfix Fix for issues blocking development, i.e. CI issues, tests failing in CI, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants