-
Notifications
You must be signed in to change notification settings - Fork 7.4k
arch: arm: Optimise Cortex-R exception return function. #20477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ioannisg
merged 1 commit into
zephyrproject-rtos:master
from
stephanosio:cortex_r_optimise_cortex_r_exc_return
Mar 14, 2020
Merged
arch: arm: Optimise Cortex-R exception return function. #20477
ioannisg
merged 1 commit into
zephyrproject-rtos:master
from
stephanosio:cortex_r_optimise_cortex_r_exc_return
Mar 14, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@stephanosio can you rebase this one, to resume reviewing? |
f011418
to
278ef9e
Compare
278ef9e
to
4e4a59d
Compare
Rebased |
@ioannisg Now that the |
4e4a59d
to
e2f3007
Compare
ioannisg
approved these changes
Mar 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
Please rebase for a fresh CI run |
FYI @bbolen |
z_arm_exc_exit (z_arm_int_exit) requires the current execution mode to be specified as a parameter (through r0). This is not necessary because this value can be directly read from CPSR. This commit modifies the exception return function to retrieve the current execution mode from CPSR and removes all provisions for passing the execution mode parameter. Signed-off-by: Stephanos Ioannidis <[email protected]>
e2f3007
to
f2c26a2
Compare
Rebased |
I'm late to the party, but looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z_arm_exc_exit (z_arm_int_exit) requires the current execution mode to
be specified as a parameter (through r0). This is not necessary because
this value can be directly read from CPSR.
This commit modifies the exception return function to retrieve the
current execution mode from CPSR and removes all provisions for passing
the execution mode parameter.
Signed-off-by: Stephanos Ioannidis [email protected]
NOTE: