Bluetooth: Mesh: Fixes Friend Add Another Update

[LingaoM]

Fixes: #20746

According MESH/NODE/FRND/FN/BV-20-C should add another
Friend Update.

Signed-off-by: Lingao Meng [email protected]

[zephyrbot]

All checks passed.

checkpatch (informational only, not a failure)

-:82: WARNING:LONG_LINE: line over 80 characters
#82: FILE: subsys/bluetooth/mesh/friend.c:1148:
+	BT_DBG("Update Previous Friend Update MD 0x%02x -> 0x%02x", upd->md, md);

- total: 0 errors, 1 warnings, 106 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: AVOID_EXTERNS BRACES CONFIG_EXPERIMENTAL CONST_STRUCT DATE_TIME FILE_PATH_CHANGES MINMAX NETWORKING_BLOCK_COMMENT_STYLE PRINTK_WITHOUT_KERN_LEVEL SPLIT_STRING VOLATILE

NOTE: If any of the errors are false positives, please report
      them to the maintainers.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

[jhedberg]

@LingoMeng could you fix the build issue? Quoting from Shippable:

/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/bluetooth/mesh/friend.c: In function 'update_overwrite':
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/bluetooth/mesh/friend.c:1204:10: error: 'return' with a value, in function returning void [-Werror]
   return false;
          ^~~~~
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/bluetooth/mesh/friend.c:1198:13: note: declared here
 static void update_overwrite(struct net_buf *buf)
             ^~~~~~~~~~~~~~~~
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/bluetooth/mesh/friend.c:1217:6: error: 'src' undeclared (first use in this function)
  if (src != net_buf_pull_be16(buf)) {
      ^~~
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/bluetooth/mesh/friend.c:1217:6: note: each undeclared identifier is reported only once for each function it appears in
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/bluetooth/mesh/friend.c: In function 'add_update':
/home/buildslave/src/github.com/zephyrproject-rtos/zephyr/subsys/bluetooth/mesh/friend.c:1243:42: error: expected ';' before '}' token
   update_overwrite((struct net_buf *)cur)
                                          ^
                                          ;
  }                                       

[trond-snekvik]

#21026 (comment)

[joerchan]

@LingoMeng You have build errors. See shippable.