arch: arm: aarch32: Allow selecting compiler instruction set #22741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
requested review from
andrewboie,
andyross,
galak,
ioannisg,
MaureenHelm,
nashif and
SebastianBoe
as code owners
This was referenced Feb 12, 2020
Closed
zephyrbot
added
area: ARM
|
All checks are passing now. Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages. |
It must be very nice having an assembler that supports do-while, I mean really. |
SebastianBoe
requested changes
Feb 12, 2020
stephanosio
force-pushed
the
arm_isa_selection
branch
from
363d2f0 to
a7e5fc4
Compare
SebastianBoe
requested changes
Feb 13, 2020
stephanosio
force-pushed
the
arm_isa_selection
branch
from
a7e5fc4 to
c34f78b
Compare
ioannisg
reviewed
Mar 10, 2020
This commit whitespace-aligns the toolchain flags. Signed-off-by: Stephanos Ioannidis <[email protected]>
This commit introduces the `COMPILER_ISA_THUMB2` symbol to allow choosing either the ARM or Thumb instruction set for C code compilation. In addition, this commit introduces the `ASSEMBLER_ISA_THUMB2` helper symbol to specify the default target instruction set for the assembler. Signed-off-by: Stephanos Ioannidis <[email protected]>
The ARMv7-R architecture supports both Thumb-2 (T32) and ARM (A32) instruction sets. This commit selects the `ISA_THUMB2` symbol to indicate that the ARMv7-R architecture supports the Thumb-2 instruction set, which can be enabled by selecting the `COMPILER_ISA_THUMB2` symbol. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
force-pushed
the
arm_isa_selection
branch
from
c34f78b to
af20257
Compare
ioannisg
reviewed
Mar 10, 2020
ioannisg
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes to allow choosing either ARM
or Thumb instruction set for C code compilation.
Introduce
COMPILER_ISA_THUMB2symbol to make C code compilationusing the Thumb instruction set configurable.
When
ISA_ARMandISA_THUMB2symbols are selected simultaneously(i.e. on Cortex-A and Cortex-R processors), make all ASM functions
use the ARM instruction set by default.
Signed-off-by: Stephanos Ioannidis [email protected]