drivers: modem: use zsock_ variants of socket API

[aport]

By using the Zephyr-native zsock_ family of types and functions, these
drivers will be decoupled from NET_SOCKETS_POSIX_NAMES.

This should help resolve part of #26033

Signed-off-by: Adam Porter [email protected]

[zephyrbot]

All checks passed.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

[jukkar]

Using zsock_... API is ok.
What is the exact issue why we need to do this, is it because the socket API gets defined twice or what?

[pfalcon]

This change looks right, the idea/convention is that internally within Zephyr codebase, we use zsock_* namespaced API.

[pfalcon]

@aport:

 -:34: WARNING:LONG_LINE: line over 80 characters
#34: FILE: drivers/modem/modem_socket.c:299:
 +		if (fds[i].events & ZSOCK_POLLIN && sock->packet_sizes[0] > 0U) {

Please deal with this line, it requires extra parens and wrapping.

[aport]

@jukkar There were two issues, first was that this driver used both zsock_ types and POSIX types interchangeably, so this converts the latter into the former for consistency.

Second issue was that the use of POSIX types forced the dependency on NET_SOCKETS_POSIX_NAMES which really should be a user option and not a driver dependency.

Currently NET_SOCKETS_OFFLOAD depends on NET_SOCKETS_POSIX_NAMES, presumably to get these drivers to compile. This change is one of several needed to cut that dependency.

At least with this change, I can compile my application without NET_SOCKETS_POSIX_NAMES.

[mike-scott]

LGTM. Thank you for submitting this change.