Fix SPI CS handling in LoRa radios #26653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add chip select flags from the device tree to the spi_cs_control instance. Signed-off-by: Andreas Sandberg <[email protected]>
Add chip select flags from the device tree to the spi_cs_control instance. Signed-off-by: Andreas Sandberg <[email protected]>
mniestroj
reviewed
Jul 5, 2020
| @@ -550,6 +550,10 @@ static int sx1276_lora_init(struct device *dev) | |||
| return -EIO; | |||
| } | |||
|
|
|||
| spi_cs.gpio_pin = GPIO_CS_PIN; | |||
| spi_cs.gpio_dt_flags = GPIO_CS_FLAGS; | |||
| spi_cs.delay = 0U; | |||
There was a problem hiding this comment.
delay is initialized to 0 anyway, because variable is declared as static. Is there a reason to specify that explicitly?
There was a problem hiding this comment.
Yeah, I realised that as well. Most other drivers that I looked at seem to do it explicitly though. Happy to drop it if you think it is a problem.
There was a problem hiding this comment.
It is just a preference, not a blocker :)
Mani-Sadhasivam
approved these changes
Jul 6, 2020
mniestroj
approved these changes
Jul 6, 2020
mniestroj
added
area: LoRa
area: SPI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CS flags from the device tree. Fixes a bug introduced by #26269.