-
Notifications
You must be signed in to change notification settings - Fork 7.4k
NXP: Enable eDMA on KE1xF SoC series #26813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NXP: Enable eDMA on KE1xF SoC series #26813
Conversation
I am putting this PR in draft mode for now due to #26812 also affecting the KE1xF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -6,7 +6,7 @@ | |||
config DMA_MCUX_EDMA | |||
bool "Enable MCUX DMA driver" | |||
depends on HAS_MCUX_EDMA | |||
select NOCACHE_MEMORY if HAS_MCUX_CACHE | |||
imply NOCACHE_MEMORY if HAS_MCUX_CACHE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the NOCACHE_MEMORY better not be disablable by users, in RT series without this, user need control the cache by them self, do you sure you want this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Problem here is, that the Kinetis KE1xF series has CONFIG_HAS_MCUX_CACHE=y
but CONFIG_ARCH_HAS_NOCACHE_MEMORY_SUPPORT=n
, so the dependency would not be fulfilled by the select
statement.
The imply
statement is like select
except that it honours dependencies. Thus for SoCs with CONFIG_HAS_MCUX_CACHE=y
that fulfils the dependencies for CONFIG_NOCACHE_MEMORY=y
the result will be the same as with the select
statement.
log for two dma cases on ke18 ` ------------------------- Target.main.com118 -------------------------
|
Moved out of draft since @hakehuang has found the cause for the DMA test failure reported in #26812. It is not related to the eDMA support on the KE1xF. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also add dma to the supported list in boards/arm/twr_ke18f/twr_ke18f.yaml
?
Only enable CONFIG_NOCACHE_MEMORY if supported by the SoC. Signed-off-by: Henrik Brix Andersen <[email protected]>
Add support for the NXP KE1xF SoC to the eDMA driver. The KE1xF supports m2m DMA transfers from sources 60 to 63. Signed-off-by: Henrik Brix Andersen <[email protected]>
Add eDMA devicetree node to the NXP KE1xF SoC devicetree. Signed-off-by: Henrik Brix Andersen <[email protected]>
Enable eDMA support. Signed-off-by: Henrik Brix Andersen <[email protected]>
Enable eDMA on the NXP TWR-KE18F development board. Signed-off-by: Henrik Brix Andersen <[email protected]>
835113e
to
e1c1d38
Compare
@MaureenHelm Thanks, added. |
This series of commits enables eDMA on the NXP KE1xF SoC series and on the NXP TWR-KE18F development board.