zperf time handling fixes #30237
Merged
zperf time handling fixes #30237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlubos
approved these changes
Nov 26, 2020
pabigot
reviewed
Dec 1, 2020
Currently the code uses hw cycles and tries to convert them to usec. I noticed some failures with this, for example the test duration was sometimes missed meaning that instead of testing 5 seconds, we bailed out after 2 sec etc. After the kernel k_timeout_t changes, which added APIs to support usec accuracy, we can use usec and ticks here. This simplifies the code a bit. Signed-off-by: Jukka Rissanen <[email protected]>
If user has enabled DHCPv4, then allow to use its address instead of giving error if static address cannot be set. Similar fix for IPv6, so allow user to manually set an IPv6 address. Because DHCPv4 has already set the IPv4 address to the network interface, then zperf might not be able to add the pre-configured address to it. So instead of returning immediately, try to use the IP address that is already in the network interface. This way we avoid this error print. uart:~$ zperf udp download 5001 Setting IP address 2001:db8::1 Setting destination IP address 2001:db8::2 Cannot set IPv4 address 192.0.2.1 Unable to set IP Setting destination IP address 192.0.2.2 Cannot set IPv4 address 192.0.2.1 Unable to set IPv4 Binding to 192.0.2.1 Cannot bind IPv4 UDP port 5001 (-2) In this example, the network interface already had a proper and working IPv4 address 192.168.0.2 in it. Signed-off-by: Jukka Rissanen <[email protected]>
|
Updated according to comments. |
I agree, the fact that some of the ticks/time/timeout functions use signed and some unsigned is quite confusing. |
pabigot
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted the code to use usec accuracy time functions that the kernel provides currently.
Also noticed IP address setting issue when testing the changes.