Skip to content

mass conversion of k_work API #33924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

mass conversion of k_work API #33924

wants to merge 22 commits into from

Conversation

pabigot
Copy link
Collaborator

@pabigot pabigot commented Mar 31, 2021

Absent an assignee to manage the conversion, use coccinelle to do a blanket translation from the deprecated API to the replacement API.

Conversions have been grouped into areas for convenience. There is no guarantee of bisectability between the resulting commits, as conversions in one commit may depend on conversions in another commit. Conversions of remaining time API are not optimized.

pabigot added 8 commits March 31, 2021 10:36
@pabigot
DNM: kwork.cocci: script for converting deprecated k_work API
8e1919f 
This is a demonstration; all uses of the k_work API should be reviewed
for correctness, rather than rote conversion.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
benchmarks: rote conversion of k_work API
8a21279 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
bluetooth: rote conversion of k_work API
5605a43 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
canbus: rote conversion of k_work API
dd4b028 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
console: rote conversion of k_work API
1a6b7d9 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
ethernet: rote conversion of k_work API
f2eb19e 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
ipc: rote conversion of k_work API
93d6e2f 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
ieee802154: rote conversion of k_work API
0344ae5 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot pabigot mentioned this pull request Mar 31, 2021
Closed
18 tasks
pabigot added 5 commits March 31, 2021 18:13
@pabigot
kernel: rote conversion of k_work API
bd8f856 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
led_sx1509b_intensity: rote conversion of k_work API
d4987a0 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
mgmt: rote conversion of k_work API
f9be435 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
modem: rote conversion of k_work API
e0e7173 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
net: rote conversion of k_work API
71a1cff 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
pabigot added 9 commits April 1, 2021 06:17
@pabigot
FIXUP net: missed uses
1acb195 
Some required transformations were missed by Coccinelle, possibly
because of parsing problems.  A commented API mis-use was fixed manual
now that the introspection isn't required, but the comment has not
been revised.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
serial: rote conversion of k_work API
ad24365 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
shell: rote conversion of k_work API
78b93df 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
tracing: rote conversion of k_work API
6a21548 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
usb: rote conversion of k_work API
8a3ea0f 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
video: rote conversion of k_work API
5772213 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
wifi: rote conversion of k_work API
45711cd 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
boards: rote conversion of k_work API
e63c3ce 
Replace all existing deprecated API with the recommended alternative.

Be aware that this does not address architectural errors in the use
of the work API.

Signed-off-by: Peter Bigot <[email protected]>
@pabigot
Revert "DNM: kwork.cocci: script for converting deprecated k_work API"
0b2668f 
This reverts commit f06feecff6159ef79bf7d6087e123a31d74e8576.

Signed-off-by: Peter Bigot <[email protected]>
@zephyrbot zephyrbot added area: Ethernet area: LWM2M area: Video Video subsystem area: UART Universal Asynchronous Receiver-Transmitter area: Bluetooth Mesh labels Apr 12, 2021
@jukkar jukkar removed their assignment Apr 12, 2021
@mnkp mnkp mentioned this pull request Apr 13, 2021
Closed
dleach02
dleach02 reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@dleach02 dleach02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help bisectability if these commits were squashed into one?

@jukkar
Copy link
Member

jukkar commented Apr 23, 2021

Would it help bisectability if these commits were squashed into one?

I thought the commits in this PR were just an examples for maintainers to use, so this PR is not to be merged as is anyway.

@pabigot pabigot mentioned this pull request May 5, 2021
Merged
@galak
Copy link
Collaborator

galak commented May 7, 2021

Closing as all code has been changed in tree now.

@galak galak closed this May 7, 2021
@trond-snekvik trond-snekvik mentioned this pull request May 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dleach02 dleach02 dleach02 left review comments

@cvinayak cvinayak cvinayak approved these changes

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@andyross andyross Awaiting requested review from andyross

@asbjornsabo asbjornsabo Awaiting requested review from asbjornsabo

@carlescufi carlescufi Awaiting requested review from carlescufi

@ceolin ceolin Awaiting requested review from ceolin

@dcpleung dcpleung Awaiting requested review from dcpleung

@erwango erwango Awaiting requested review from erwango

@FRASTM FRASTM Awaiting requested review from FRASTM

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@ioannisg ioannisg Awaiting requested review from ioannisg

@jakub-uC jakub-uC Awaiting requested review from jakub-uC

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

Assignees
No one assigned
Labels
area: API Changes to public APIs area: Bluetooth Controller area: Bluetooth Mesh area: Bluetooth area: CAN area: Console area: Ethernet area: IEEE 802.15.4 area: Kernel area: LED Label to identify LED subsystem area: LWM2M area: Modem area: Networking area: Shell Shell subsystem area: Sockets Networking sockets area: Tracing Tracing area: UART Universal Asynchronous Receiver-Transmitter area: USB Universal Serial Bus area: Video Video subsystem area: Wi-Fi Wi-Fi platform: nRF Nordic nRFx platform: NXP NXP platform: STM32 ST Micro STM32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pabigot @jukkar @galak @cvinayak @dleach02 @zephyrbot