tests: posix: common: clock: remove poorly conditioned tests #38158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: Tests
The test assumed initial equality between CLOCK_MONOTONIC and CLOCK_REALTIME and also assumed coarse granularity for each clock. Neither of those assumptions are solid. Furthermore, the test failed on multiple vendor boards which caused some concern. Remove the poorly conditioned tests and remove some comments / printks. Fixes zephyrproject-rtos#35703 Signed-off-by: Christopher Friedt <[email protected]>
cfriedt
force-pushed
the
issue/35703/posix-api-fails-at-test-posix-realtime-for-mimxrt1024-evk
branch
from
378625e to
0d4bfc3
Compare
dleach02
reviewed
Aug 31, 2021
dleach02
reviewed
Aug 31, 2021
dleach02
approved these changes
Aug 31, 2021
nashif
approved these changes
Sep 10, 2021
cfriedt
deleted the
issue/35703/posix-api-fails-at-test-posix-realtime-for-mimxrt1024-evk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test assumed initial equality between CLOCK_MONOTONIC and CLOCK_REALTIME and also assumed coarse granularity for each clock. Neither of those assumptions are solid.
Furthermore, the test failed on multiple vendor boards which caused some concern.
Remove the poorly conditioned tests and remove some comments / printks.
Fixes #35703