drivers: sensors: Add driver for AHT20 temperature humidity sensor.

[RafaelLeeImg]

Support AHT20 Temperature and Humidity Sensor with I2C bus

Webpage for the sensor is here:
https://asairsensors.com/product/aht20-integrated-temperature-and-humidity-sensor/

Data sheet v1.0.03 is here:
https://asairsensors.com/wp-content/uploads/2021/09/Data-Sheet-AHT20-Humidity-and-Temperature-Sensor-ASAIR-V1.0.03.pdf

Tested with physical sensor.
arm-none-eabi-gcc (15:10.3-2021.07-4) 10.3.1 20210621 (release)

[gmarull]

Did an initial review, there are quite a few issues that need to be addressed.

[teburd]

Primarily the k_busy_wait concerns me

[teburd]

This looks pretty good, the comments need to use /* */ rather than // though, and I believe checkpatch will fail on those.

If you plan on contributing a lot to zephyr I recommend setting up checkpatch as a git hook.
See https://docs.zephyrproject.org/latest/contribute/index.html#coding-style

[RafaelLeeImg]

I used both clang-format and uncrustify to format my source code, but the space before the colon is introduced by uncrustify, if there is no proper tool to format code. I'm using version Uncrustify-0.72.0_f, is my version too old? Otherwise, it's better to fix the uncrustify config instead of modify the code format by hand.

uncrustify --replace --no-backup -l C -c $ZEPHYR_BASE/.uncrustify.cfg aht20.c

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

[ssekar15]

@RafaelLeeImg we are interested on this driver, do you have plan to continue with the PR !!

[RafaelLeeImg]

@RafaelLeeImg we are interested on this driver, do you have plan to continue with the PR !!

Hi.
I would like to continue with the current PR. I've already formatted the code according to the coding style proposed by

uncrustify --replace --no-backup -l C -c $ZEPHYR_BASE/.uncrustify.cfg

But, at the stage, the CI still complains coding formats error.
I think make every tiny format modification and let CI tell me where I'm wrong is very inefficient.
Have the .uncrustify.cfg or CI script updated?

[RafaelLeeImg]

CI failed due to fail to fetch packages.
#52298

[RafaelLeeImg]

How to generate this symbol DT_HAS_ASAIR_AHT20_ENABLED ?
I didn't find any clue.

[ssekar15]

DT_HAS_ASAIR_AHT20_ENABLED

^^ drop on kconfig.
please check example of dts binding in dts/bindings/sensor

add vendor prefix in dts/bindings/vendor-prefixes.txt
add dts entry for this sensor on tests/drivers/build_all/sensor/i2c.dtsi

It seems humidity value is needs to be corrected according to datasheet it has to be multiplied by 100

   	-val->val2 = (drv_data->humidity) * 1000000LL / (1 << AHT20_FULL_RANGE_BITS);
   	+val->val2 = ((drv_data->humidity) * 1000000LL / (1 << AHT20_FULL_RANGE_BITS)) * 100;

[RafaelLeeImg]

I have wrote a test demo, the data format is right. Datasheet wrote RH[%]=(S_rh/2^20)*100%, 100% is 1.0.

[RafaelLeeImg]

H.val1 = 0, H.val2 = 335938, T.val1 = 14, T.val2 = 633667;
H = 0.335938, T=14.633667;
H = 33.59%, T = 14.63;
H = 33.5938%, T = 14.63;

[RafaelLeeImg]

Is there any further modifications required?

[MaureenHelm]

The compliance check failure still needs to be addressed

[MaureenHelm]

Return an errno

[MaureenHelm]

Move this to a const config struct

[ssekar15]

@RafaelLeeImg ping

[github-actions]

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.