Skip to content

drivers: serial: added UART interrupts for Raspberry Pi Pico board #42421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andrei-edward-popa
Copy link
Contributor

Added UART Interrupt Driven driver for Raspberry Pi Pico board.

Signed-off-by: Andrei-Edward Popa [email protected]

@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch 2 times, most recently from a5ae194 to 3edc873 Compare February 2, 2022 17:31
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch 4 times, most recently from d84639d to 1240517 Compare February 2, 2022 19:58
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch from 1240517 to 9912e69 Compare February 3, 2022 12:11
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch 3 times, most recently from 9fd8576 to 590e2a6 Compare February 3, 2022 12:35
@zephyrbot zephyrbot added the area: UART Universal Asynchronous Receiver-Transmitter label Feb 3, 2022
@zephyrbot zephyrbot requested a review from dcpleung February 3, 2022 12:36
added zephyr shell to be used on uart0 instance

Signed-off-by: Andrei-Edward Popa <[email protected]>
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch from 590e2a6 to a5113a7 Compare February 3, 2022 12:47
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch 2 times, most recently from 573dc5c to 0ca000e Compare February 3, 2022 13:42
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch from 0ca000e to 8517258 Compare February 3, 2022 18:10
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch from 8517258 to cfaf6b4 Compare February 3, 2022 18:12
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch from cfaf6b4 to 08c72a9 Compare February 3, 2022 21:25
@andrei-edward-popa
Copy link
Contributor Author

@dcpleung Hi! Can you review my code? :)

Copy link
Member

@dcpleung dcpleung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please move the introduction of variables to the correct commit.

Andrei-Edward Popa added 4 commits February 4, 2022 21:16
if peripheral clock is not configured, uart init API function returns 0,
so we need to check the return value of this function

Signed-off-by: Andrei-Edward Popa <[email protected]>
added UART interrupts driver for Raspberry Pi Pico board
moved baudrate from config to data structure

Signed-off-by: Andrei-Edward Popa <[email protected]>
enabled UART interrupt driven

Signed-off-by: Andrei-Edward Popa <[email protected]>
replaced high level API functions with register access

Signed-off-by: Andrei-Edward Popa <[email protected]>
@andrei-edward-popa andrei-edward-popa force-pushed the rpi_pico_uart_interrupt_driven branch from 08c72a9 to 21224c8 Compare February 4, 2022 19:19
@nashif nashif merged commit e11077d into zephyrproject-rtos:main Feb 5, 2022
@andrei-edward-popa andrei-edward-popa deleted the rpi_pico_uart_interrupt_driven branch February 11, 2022 23:27
@andrei-edward-popa andrei-edward-popa restored the rpi_pico_uart_interrupt_driven branch May 4, 2022 13:05
@andrei-edward-popa andrei-edward-popa deleted the rpi_pico_uart_interrupt_driven branch May 4, 2022 13:05
@andrei-edward-popa andrei-edward-popa restored the rpi_pico_uart_interrupt_driven branch May 4, 2022 13:06
@andrei-edward-popa andrei-edward-popa deleted the rpi_pico_uart_interrupt_driven branch May 4, 2022 13:06
@str4t0m str4t0m added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Boards area: Devicetree area: UART Universal Asynchronous Receiver-Transmitter platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants