-
Notifications
You must be signed in to change notification settings - Fork 7.3k
drivers: serial: added UART interrupts for Raspberry Pi Pico board #42421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nashif
merged 5 commits into
zephyrproject-rtos:main
from
andrei-edward-popa:rpi_pico_uart_interrupt_driven
Feb 5, 2022
Merged
drivers: serial: added UART interrupts for Raspberry Pi Pico board #42421
nashif
merged 5 commits into
zephyrproject-rtos:main
from
andrei-edward-popa:rpi_pico_uart_interrupt_driven
Feb 5, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a5ae194
to
3edc873
Compare
gmarull
requested changes
Feb 2, 2022
d84639d
to
1240517
Compare
gmarull
reviewed
Feb 3, 2022
1240517
to
9912e69
Compare
gmarull
reviewed
Feb 3, 2022
9fd8576
to
590e2a6
Compare
added zephyr shell to be used on uart0 instance Signed-off-by: Andrei-Edward Popa <[email protected]>
590e2a6
to
a5113a7
Compare
pirearadu
reviewed
Feb 3, 2022
pirearadu
reviewed
Feb 3, 2022
pirearadu
reviewed
Feb 3, 2022
573dc5c
to
0ca000e
Compare
gmarull
reviewed
Feb 3, 2022
0ca000e
to
8517258
Compare
8517258
to
cfaf6b4
Compare
gmarull
approved these changes
Feb 3, 2022
cfaf6b4
to
08c72a9
Compare
@dcpleung Hi! Can you review my code? :) |
dcpleung
requested changes
Feb 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please move the introduction of variables to the correct commit.
if peripheral clock is not configured, uart init API function returns 0, so we need to check the return value of this function Signed-off-by: Andrei-Edward Popa <[email protected]>
added UART interrupts driver for Raspberry Pi Pico board moved baudrate from config to data structure Signed-off-by: Andrei-Edward Popa <[email protected]>
enabled UART interrupt driven Signed-off-by: Andrei-Edward Popa <[email protected]>
replaced high level API functions with register access Signed-off-by: Andrei-Edward Popa <[email protected]>
08c72a9
to
21224c8
Compare
dcpleung
approved these changes
Feb 4, 2022
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: Boards
area: Devicetree
area: UART
Universal Asynchronous Receiver-Transmitter
platform: Raspberry Pi Pico
Raspberry Pi Pico (RPi Pico)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added UART Interrupt Driven driver for Raspberry Pi Pico board.
Signed-off-by: Andrei-Edward Popa [email protected]