rpi_pico: Add hwinfo support #42558
rpi_pico: Add hwinfo support #42558
Conversation
modules/hal_rpi_pico/CMakeLists.txt
Outdated
| # A function in flash.c adds 1 to a function pointer, causing a warning | ||
| set_source_files_properties( | ||
| ${rp2_common_dir}/hardware_flash/flash.c | ||
| PROPERTIES | ||
| COMPILE_FLAGS "-Wno-pointer-arith" | ||
| ) |
There was a problem hiding this comment.
good that disabling of such warning is local to the file in question.
However, we generally try to avoid adding compiler specific flags directly on sources / libs as they may not be supported on all compilers.
Could you add an extra entry in those two files, and then fetch the property before calling set_source_files_properties():
https://github.com/zephyrproject-rtos/zephyr/blob/main/cmake/compiler/compiler_flags_template.cmake
https://github.com/zephyrproject-rtos/zephyr/blob/main/cmake/compiler/gcc/compiler_flags.cmake
drivers/hwinfo/hwinfo_rpi_pico.c
Outdated
| { | ||
| /* The reset register can't be erased, nothing to do. */ | ||
|
|
||
| return 0; |
There was a problem hiding this comment.
-ENOSUP would be more precise here.
|
@yonsch I have to apologize. I told you the wrong errno. |
|
@alexanderwachter Can you take another look? |
Add a compiler property for disabling pointer arithmetic warnings, and implement that property for GCC. Signed-off-by: Yonatan Schachter <[email protected]>
Support function and data lookup in the RPi's ROM. The objects are obtained by including <pico/bootrom.h> and calling rom_func_lookup or rom_data_lookup. Signed-off-by: Yonatan Schachter <[email protected]>
Added support for hwinfo's hwinfo_get_device_id for the RPi Pico series. Signed-off-by: Yonatan Schachter <[email protected]>
Added support for hwinfo's reset cause functions, for the Raspberry Pi Pico series. Signed-off-by: Yonatan Schachter <[email protected]>
Adds HWINFO to rpi_pico.yaml and documentation Signed-off-by: Yonatan Schachter <[email protected]>
Fix hwinfo documentation claiming API returns ENOTSUP for unimplemented functions, with the correct ENOSYS Signed-off-by: Yonatan Schachter <[email protected]>
Adds hwinfo support for the rpi_pico series. Additionally, support for calling bootrom functions was added.