Skip to content

doc: getting_started: Add instructions for multi-platform Zephyr SDK #43008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

stephanosio
Copy link
Member

@stephanosio stephanosio commented Feb 21, 2022

This commit adds the Linux, macOS and Windows instructions for
installing the new multi-platform Zephyr SDK.

Signed-off-by: Stephanos Ioannidis <[email protected]>

Zephyr SDK 0.14.0.

Copy link
Contributor

@mbolivar-nordic mbolivar-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I don't understand the naming, though. I thought we discussed at the TSC that this was going to be renamed from "Zephyr SDK", because there was too much potential for confusion in the embedded space with "vendor SDK", which includes all the firmware libraries etc for developing on an SoC. Did I misunderstand something?

@stephanosio stephanosio force-pushed the mp_sdk_doc_update branch 2 times, most recently from 7ec3584 to 9f2a9ad Compare March 5, 2022 04:58
@stephanosio stephanosio marked this pull request as ready for review March 9, 2022 09:39
@stephanosio stephanosio added the DNM This PR should not be merged (Do Not Merge) label Mar 9, 2022
@stephanosio
Copy link
Member Author

Ready for review. DNM until Zephyr SDK 0.14.0 is released.

@stephanosio
Copy link
Member Author

Zephyr SDK 0.14.0 has been released.

Ready for final review and merging.

@stephanosio stephanosio removed the DNM This PR should not be merged (Do Not Merge) label Mar 16, 2022
@stephanosio
Copy link
Member Author

@carlescufi @gmarull @mbolivar-nordic Could you review this so that we can merge it and announce the SDK 0.14.0 release?

gmarull
gmarull previously approved these changes Mar 17, 2022
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment

Copy link
Member

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, some changes requested. Also, can you please update the Set up a toolchain section? This paragraph is now wrong:

On Linux systems, you can install the Zephyr SDK to get toolchains for all supported architectures. Otherwise, you can install other toolchains in the usual way for your operating system: with installer programs or system package managers, by downloading and extracting a zip archive, etc.

Copy link
Collaborator

@FrancescoSer FrancescoSer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Proposing a few small changes to the text.

This commit adds the instruction for installing the `wget` application
for macOS and Windows hosts, such that it is available on all three
host platforms when the Getting Started Guide is followed.

The rationale behind this is as follows:

  * The Zephyr documentations, including the Getting Started Guide,
    makes extensive use of the wget command.

  * wget is a purpose-made tool for get/download requests and is more
    user-friendly than curl for the purpose of downloading files.

Signed-off-by: Stephanos Ioannidis <[email protected]>
FrancescoSer
FrancescoSer previously approved these changes Mar 28, 2022
This commit adds the Linux, macOS and Windows instructions for
installing the new multi-platform Zephyr SDK.

Signed-off-by: Stephanos Ioannidis <[email protected]>
Since Zephyr SDK is now supported on all major operating systems, there
is no need to restrict it to "on Linux."

This commit also removes an endorsement of the GNU Arm Embedded
toolchain because there is no need to recommend and/or use it anymore
for the aforementioned reason.

Signed-off-by: Stephanos Ioannidis <[email protected]>
Copy link
Member

@gmarull gmarull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one minor suggestion

wget https://github.com/zephyrproject-rtos/sdk-ng/releases/download/v0.14.0/zephyr-sdk-0.14.0_macos-x86_64.tar.gz
wget -O - https://github.com/zephyrproject-rtos/sdk-ng/releases/download/v0.14.0/sha256.sum | shasum --check --ignore-missing

If your host architecture is 64-bit ARM (Apple Silicon, also known as M1), replace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd personally remove M1 references, I'm pretty sure we'll have M2 or M1plus or whatever at some point.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know, Apple is currently working on the "M2" chip; but, as of now, all the production Macs are M1 and they refer to those as "M1" in the marketing materials too.

I think we can update/generalise this later when they actually have multiple M series SoCs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just mentioning Apple Sillicon means we don't have to keep updating the document when, e.g., M2 is released.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @gmarull, let's stick to "Apple Silicon". Please send a follow-up PR @stephanosio.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://www.apple.com/mac-mini/, they almost exclusively refer to their Arm-based Mac Minis as "M1" and there is not a single mention of the "Apple Silicon" on that page (from what I can see, they stopped using the "Apple Silicon" term, at least in the marketing materials); in that sense, I think it is helpful to keep that "aka. M1" for now.

When they release a new M series SoC, I will make sure to send a follow-up PR either generalising that phrase or just completely removing it.

@carlescufi carlescufi merged commit 989b71b into zephyrproject-rtos:main Mar 29, 2022
@stephanosio stephanosio added the backport v2.7-branch Request backport to the v2.7-branch label Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Documentation backport v2.7-branch Request backport to the v2.7-branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants