Skip to content

drivers: watchdog: Add Raspberry Pi Pico watchdog driver #43393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 6, 2022
Merged

drivers: watchdog: Add Raspberry Pi Pico watchdog driver #43393

merged 5 commits into from
Jul 6, 2022

Conversation

thedjnK
Copy link
Collaborator

@thedjnK thedjnK commented Mar 2, 2022

This adds basic support for the watchdog timer on the RP2040 MCU and
Raspberry Pi Pico development board

Tested on a raspberry pi pico board with a modified hello world sample, board reboots after ~8 seconds

@github-actions github-actions bot added area: Boards area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding area: Watchdog Watchdog labels Mar 2, 2022
katsuster
katsuster previously approved these changes Mar 14, 2022
View reviewed changes
@thedjnK
Copy link
Collaborator Author

thedjnK commented Apr 20, 2022

@yonsch could you give this a review?

yonsch
yonsch reviewed Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@yonsch yonsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert on Zephyr's WD API nor the pico's WD, but here's what I could find

@thedjnK thedjnK requested a review from nashif as a code owner April 23, 2022 11:06
@github-actions github-actions bot added area: Documentation area: Tests Issues related to a particular existing or missing test Release Notes To be mentioned in the release notes labels Apr 23, 2022
@thedjnK thedjnK requested a review from katsuster April 23, 2022 11:08
@yonsch yonsch added the platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) label May 1, 2022
petejohanson
petejohanson reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with the WDT stuff, but a couple general items I noticed.

petejohanson
petejohanson reviewed May 13, 2022
View reviewed changes
Copy link
Contributor

@petejohanson petejohanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other minor nitpick I noticed.

@thedjnK thedjnK requested a review from yonsch May 14, 2022 13:28
yonsch
yonsch previously approved these changes May 15, 2022
View reviewed changes
Copy link
Collaborator

@yonsch yonsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

martinjaeger
martinjaeger previously approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@martinjaeger martinjaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have any experience with RPi Pico, but the watchdog code looks very clean and sound. I assume you have successfully tested it in hardware.

As we just passed feature freeze for v3.1 we'll need to wait till the release beginning of June for this to get merged.

@mbolivar-nordic mbolivar-nordic added this to the v3.2.0 milestone May 18, 2022
@mbolivar-nordic mbolivar-nordic removed this from the v3.2.0 milestone May 18, 2022
@mbolivar-nordic
Copy link
Contributor

twister is failing; @thedjnK can you please take a look?

@thedjnK thedjnK dismissed stale reviews from martinjaeger and yonsch via 7a8c5cc May 18, 2022 17:14
@thedjnK
Copy link
Collaborator Author

thedjnK commented May 18, 2022

Yes, the basic wdt test passes on the device.

@thedjnK thedjnK requested review from martinjaeger and yonsch May 18, 2022 17:53
@yonsch
Copy link
Collaborator

yonsch commented May 18, 2022

@thedjnK One thing I forgot - please add watchdog to the table of supported features in the board's doc

katsuster
katsuster previously approved these changes May 24, 2022
View reviewed changes
@yonsch
Copy link
Collaborator

yonsch commented Jun 23, 2022

@thedjnK Please rebase, add the watchdog to the documentation, and remove the release notes change. Then I think we can merge this.

@carlescufi
Copy link
Member

@yonsch would you mind taking over the PR and force-pushing the changes so we can get this merged?

thedjnK added 4 commits July 5, 2022 20:38
@thedjnK
drivers: watchdog: Add Raspberry Pi Pico watchdog driver
82b37c9 
This adds basic support for the watchdog timer on the RP2040 MCU and
Raspberry Pi Pico development board

Signed-off-by: Jamie McCrae <[email protected]>
@thedjnK
tests: drivers: watchdog: Add RPI Pico support
a9f92ab 
Adds support for running the wdt test on the Raspberry Pi Pico by
increasing the window size and disabling timeouts.

Signed-off-by: Jamie McCrae <[email protected]>
@thedjnK
doc: guides: release notes: Add Raspberry Pi Pico watchdog support
1b20b3e 
The Raspberry Pi Pico watchdog is now supported, this adds a note to
the release notes with this information.

Signed-off-by: Jamie McCrae <[email protected]>
@thedjnK
boards: rpi_pico: Added Watchdog timer to supported feature list
900391a 
Adds Watchdog timer (WDT) to the list of supported features for the
Raspberry Pi Pico board.

Signed-off-by: Jamie McCrae <[email protected]>
@zephyrbot zephyrbot requested review from carlescufi, gmarull and utzig July 5, 2022 19:53
@thedjnK
samples: drivers: watchdog: Add support for Raspberry Pi Pico
ed1f45f 
This adds support for running the watchdog driver sample on a Raspberry
Pi Pico board.

Signed-off-by: Jamie McCrae <[email protected]>
@carlescufi carlescufi merged commit db46978 into zephyrproject-rtos:main Jul 6, 2022
@thedjnK thedjnK deleted the rpiwdt branch August 30, 2022 21:37
@soburi soburi mentioned this pull request Jan 16, 2023
Open
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petejohanson petejohanson petejohanson approved these changes

@carlescufi carlescufi carlescufi approved these changes

@yonsch yonsch yonsch approved these changes

@katsuster katsuster katsuster left review comments

@galak galak Awaiting requested review from galak

@mbolivar-nordic mbolivar-nordic Awaiting requested review from mbolivar-nordic

@nashif nashif Awaiting requested review from nashif

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@gmarull gmarull Awaiting requested review from gmarull

@utzig utzig Awaiting requested review from utzig

Assignees
No one assigned
Labels
area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Documentation area: Tests Issues related to a particular existing or missing test area: Watchdog Watchdog platform: Raspberry Pi Pico Raspberry Pi Pico (RPi Pico) Release Notes To be mentioned in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thedjnK @mbolivar-nordic @yonsch @carlescufi @petejohanson @katsuster @martinjaeger