Skip to content

Normalize .cc extensions to .cpp #44517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

Normalize .cc extensions to .cpp #44517

merged 1 commit into from
Apr 11, 2022

Conversation

yperess
Copy link
Collaborator

@yperess yperess commented Apr 4, 2022

Rename all .cc files to .cpp (note that no .hh files were found).
Addresses #44196

Signed-off-by: Yuval Peress [email protected]

@yperess yperess requested a review from nashif as a code owner April 4, 2022 16:37
@github-actions github-actions bot added the area: Samples Samples label Apr 4, 2022
@yperess yperess requested a review from stephanosio April 4, 2022 17:22
stephanosio
stephanosio reviewed Apr 4, 2022
View reviewed changes
Copy link
Member

@stephanosio stephanosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

What about the h to hpp changes?

@yperess
Copy link
Collaborator Author

yperess commented Apr 4, 2022

I ran the same for .hh but couldn't find any.
Going through the pain .h files to see which are strictly C++ will have to be done by hand and will take longer.

@stephanosio
Copy link
Member

I ran the same for .hh but couldn't find any.
Going through the pain .h files to see which are strictly C++ will have to be done by hand and will take longer.

Here I am mainly referring to the h files in the same directories as these cpp files.

@yperess
samples: Normalize .cc extensions to .cpp
3f6c10e 
Rename all .cc files to .cpp (note that no .hh files were found).
Addresses zephyrproject-rtos#44196

Signed-off-by: Yuval Peress <[email protected]>
@yperess
Copy link
Collaborator Author

yperess commented Apr 5, 2022

I ran the same for .hh but couldn't find any.
Going through the pain .h files to see which are strictly C++ will have to be done by hand and will take longer.

Here I am mainly referring to the h files in the same directories as these cpp files.

Gotcha, OK, some headers were used by .c files so I left those with .h, but updated the rest.

@yperess yperess requested a review from stephanosio April 5, 2022 16:46
laurenmurphyx64
laurenmurphyx64 approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@laurenmurphyx64 laurenmurphyx64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the changes.

@laurenmurphyx64 laurenmurphyx64 mentioned this pull request Apr 11, 2022
Merged
@MaureenHelm MaureenHelm merged commit a98f5d7 into zephyrproject-rtos:main Apr 11, 2022
@yperess yperess deleted the rename-cc-files branch December 6, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@stephanosio stephanosio stephanosio approved these changes

@laurenmurphyx64 laurenmurphyx64 laurenmurphyx64 approved these changes

@nashif nashif Awaiting requested review from nashif

Assignees
No one assigned
Labels
area: C++ area: Samples Samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yperess @stephanosio @MaureenHelm @laurenmurphyx64