Skip to content

docs: Raspberry Pi Pico board page document fix for pwm #47578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2022
Merged

docs: Raspberry Pi Pico board page document fix for pwm #47578

merged 1 commit into from
Jul 17, 2022

Conversation

MrGreensWorkshop
Copy link
Contributor

@MrGreensWorkshop MrGreensWorkshop commented Jul 9, 2022 •
edited
Loading

https://docs.zephyrproject.org/latest/boards/arm/rpi_pico/doc/index.html

There was a format problem on Supported Features table last element of pwm.

Screen Shot 2022-07-09 at 19 33 55

@MrGreensWorkshop MrGreensWorkshop requested a review from nashif as a code owner July 9, 2022 10:38
@MrGreensWorkshop MrGreensWorkshop changed the title Raspberry Pi Pico board page document fix for pwm docs: Raspberry Pi Pico board page document fix for pwm Jul 9, 2022
@carlescufi carlescufi requested review from gmarull and yonsch July 14, 2022 14:47
carlescufi
carlescufi requested changes Jul 14, 2022
View reviewed changes
@yonsch
Copy link
Collaborator

yonsch commented Jul 14, 2022

Thanks @MrGreensWorkshop , please squash the commits, other than that, LGTM

@MrGreensWorkshop MrGreensWorkshop mentioned this pull request Jul 15, 2022
Closed
@MrGreensWorkshop MrGreensWorkshop deleted the patch-1 branch July 15, 2022 00:26
@MrGreensWorkshop MrGreensWorkshop restored the patch-1 branch July 16, 2022 03:02
@MrGreensWorkshop
Copy link
Contributor Author

MrGreensWorkshop commented Jul 16, 2022 •
edited
Loading

from Mr. @carlescufi

Compliance is failing. Please do not close the PR. Amend your commit locally and then force push to your fork’s branch

Done.

carlescufi
carlescufi previously approved these changes Jul 16, 2022
View reviewed changes
yonsch
yonsch previously approved these changes Jul 17, 2022
View reviewed changes
carlescufi
carlescufi previously approved these changes Jul 17, 2022
View reviewed changes
@MrGreensWorkshop @carlescufi
doc: Raspberry Pi Pico board page document fix for pwm
880659a 
There was problem a format mistake on Supported Features table last
element pwm. Fixed by removing spaces and adding option

Signed-off-by: Mr. Green's Workshop <[email protected]>
Co-authored-by: Carles Cufí <[email protected]>
@MrGreensWorkshop MrGreensWorkshop dismissed stale reviews from carlescufi and yonsch via 880659a July 17, 2022 11:43
@carlescufi carlescufi requested a review from yonsch July 17, 2022 11:54
@carlescufi carlescufi merged commit 0af66ad into zephyrproject-rtos:main Jul 17, 2022
@MrGreensWorkshop MrGreensWorkshop deleted the patch-1 branch July 17, 2022 12:16
@MrGreensWorkshop
Copy link
Contributor Author

@carlescufi
I appreciate your patience and help. Thank you.

@soburi soburi mentioned this pull request Jan 16, 2023
Open
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlescufi carlescufi carlescufi approved these changes

@yonsch yonsch yonsch approved these changes

@nashif nashif Awaiting requested review from nashif

@gmarull gmarull Awaiting requested review from gmarull

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrGreensWorkshop @yonsch @carlescufi