drivers: pwm: Channel > 1 not working on rp2040 (Raspberry Pi Pico) #50876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonsch
previously approved these changes
Oct 3, 2022
|
It took me a long time to figure out, why PWM doesn't work. Even the "samples" don't work on a RPi Pico. I testet Pin 2 (with a scope) and Pin 25 (onboard LED). And if you just look at valid parameters for "pwm_set_chan_level" it's clear the "full" channel number (2, 25) cannot work. |
68ec020
force-pushed
the
pico_pwm_bugfix
branch
from
39c71c5 to
f8cbd69
Compare
|
I just realised, I used my work email. And I didn't sign-off the commit. It is fixed (I hope) in the force-push. |
68ec020
requested review from
yonsch
and removed request for
henrikbrixandersen,
anangl and
gmarull
pwm_set_chan_level uses slice channels A(=0) or B(=1) and not Zephyr channel (0..15). So PWM doesn't work for channels > 1. There is already a function (pwm_rpi_channel_to_pico_channel) which does the right thing, but it isn't used for pwm_set_chan_level. Signed-off-by: Jan Hilsdorf <[email protected]>
68ec020
force-pushed
the
pico_pwm_bugfix
branch
from
f8cbd69 to
5351c58
Compare
|
Sorry, another force push, to get the compliance checks fixed. I'm really sorry. |
|
Don't worry, we all do that :) |
|
I tested it successfully on two pins (2 and 25). If you want, I can try it on all available pins (maybe except one pair of UART pins). |
|
A few random pins should be fine |
yonsch
approved these changes
Oct 3, 2022
anangl
approved these changes
Oct 4, 2022
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pwm_set_chan_level uses slice channels A(=0) or B(=1) and not Zephyr channel (0..15). So PWM doesn't work for channels > 1. There is already a function (pwm_rpi_channel_to_pico_channel) which does the right thing, but it isn't used for pwm_set_chan_level.