cmake: Deprecate 'xtools' toolchain variant #51334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanosio
force-pushed
the
deprecate_xtools
branch
from
56624f7 to
968d3c7
Compare
tejlmand
requested changes
Nov 1, 2022
The `xtools` toolchain variant (aka. Crosstool-NG) was originally introduced to be used with the Crosstool-NG-based Zephyr SDK toolchains (i.e. sdk-ng). This is no longer necessary because the current Zephyr SDK (sdk-ng) already has its own `zephyr` toolchain variant, which fully replaces the `xtools` toolchain variant, and the `xtools` toolchain variant serves no purpose at all. Signed-off-by: Stephanos Ioannidis <[email protected]>
stephanosio
force-pushed
the
deprecate_xtools
branch
from
968d3c7 to
183ad81
Compare
gmarull
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xtoolstoolchain variant (aka. Crosstool-NG) was originally introduced to be used with the Crosstool-NG-based Zephyr SDK toolchains (i.e. sdk-ng).This is no longer necessary because the current Zephyr SDK (sdk-ng) already has its own
zephyrtoolchain variant, which fully replaces thextoolstoolchain variant, and thextoolstoolchain variant serves no purpose at all.Related to #51332