rp2040: Bugfix UART initialisation: Mixup of Zephyr constants and rpi-hal constants #52348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
68ec020
force-pushed
the
rp2040-uart-initialization
branch
3 times, most recently
from
73cda38 to
971e4a8
Compare
dcpleung
previously approved these changes
Nov 17, 2022
rpi-hal function "uart_set_format" expects data width in the range of 5..8. So I created a new function “uart_rpi_set_format” which contains common parts of “uart_rpi_configure”. Signed-off-by: Jan Hilsdorf <[email protected]>
68ec020
force-pushed
the
rp2040-uart-initialization
branch
from
971e4a8 to
a216287
Compare
|
I decided I didn't like the baud rate being set twice. So a change the code a bit. I created a new function "uart_rpi_set_format" which contains everything from "uart_rpi_configure" which is format related. This function is then used in "uart_rpi_init" and "uart_rpi_configure". |
nordicjm
approved these changes
Nov 18, 2022
|
@68ec020 Thanks. Did you check that dynamic configuration still works? |
dcpleung
approved these changes
Nov 18, 2022
|
I just wrote a small test program to switch between 115200 and 9600 every second. It works as expected. |
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpi-hal function "uart_set_format" expects data width in the range of 5..8. So you can't use the Zephyr abstraction constant UART_CFG_DATA_BITS_8 directly, because its value is 3. There is already a translation in "uart_rpi_configure", but it is not used for the default initialisation. So I reused "uart_rpi_configure". There is only one downside: It also sets the baud rate, which is already done in "uart_rpi_init".