-
Notifications
You must be signed in to change notification settings - Fork 7.3k
rpi_pico: Fix DTC warnings #53431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpi_pico: Fix DTC warnings #53431
Conversation
The pinctrl node of the RP2040 had the same unit address as the GPIO bank, causing a DTC warning. To fix this, the pinctrl's address was removed, as it does not require any. Signed-off-by: Yonatan Schachter <[email protected]>
Not an RPI pico expert and got some questions:
|
The addresses of the flash and flash controller of the RP2040 SoC were mixed up. There was no clear distinction between the flash and the flash controller, which was unclear but also caused a DTC warning. This commit makes the distinction clearer: The SSI peripheral at 0x18000000 is the flash controller, and the flash itself starts at 0x10000000. The flash driver and rpi_pico.dts were fixed accordingly. Signed-off-by: Yonatan Schachter <[email protected]>
5fcab80
to
d570422
Compare
@de-nordic The RP2040 uses an external flash, that is always mapped to |
I have accepted the solution as is. But still have some questions that may require some discussion and addressing. So the HAL determines how this works, the DTS only describes the state for the Zephyr. If HAL exports the configuration via some header, shouldn't it be used in the driver rather than the DTS? |
This PR fixes two DTC warnings that have been present for some time:
and:
The first was caused by the pinctrl and gpio bank sharing the same unit address. The RP2040 doesn't have an actual pin control unit, so it does not need a unit address.
The second was caused by a conflict of the unit address of the flash as defined by the SoC and the board. There wasn't a clear distinction between the flash controller and the flash itself. This was fixed for the SoC, board and driver.