drivers: sensors: Add support for RaspberryPi Pico CPU temperature #53591
Conversation
soburi
requested review from
nashif,
MaureenHelm,
galak and
yonsch
as code owners
zephyrbot
added
area: Sensors
| / { | ||
| aliases { | ||
| cputemp0 = &coretemp; | ||
| }; | ||
| }; | ||
|
|
||
| &coretemp { | ||
| status = "okay"; | ||
| }; |
There was a problem hiding this comment.
Is there a reason you implemented this as an overlay instead of doing it in the board dts?
There was a problem hiding this comment.
aliase clause move to rp2040.dts.
Still default disabled the die-temp node.
So keeping remain the overlay for enabling it.
drivers/sensor/rpi_pico_temp/Kconfig
Outdated
| bool "Raspberry Pi Pico CPU Temperature Sensor" | ||
| default y | ||
| depends on DT_HAS_RASPBERRYPI_PICO_TEMP_ENABLED | ||
| depends on (ADC && SOC_SERIES_RP2XXX) |
There was a problem hiding this comment.
You already have a dependency on the dts compatible, so I think you can remove the redundant dependency on the SOC_SERIES
There was a problem hiding this comment.
It make a sense.
Removed SOC_SERIES_RP2XXX.
|
|
||
| vbe: | ||
| type: int | ||
| default: 706000 |
There was a problem hiding this comment.
Please justify the default value in the description
There was a problem hiding this comment.
Add short description for clarify it is a spec.
|
|
||
| vbe-slope: | ||
| type: int | ||
| default: -1721 |
There was a problem hiding this comment.
Please justify the default value in the description
There was a problem hiding this comment.
Add short description for clarify it is a spec.
Support for the measuring the CPU die temperature for the RaspberryPi Pico. Signed-off-by: TOKITA Hiroshi <[email protected]>
Renamed to die-temp[n]. |
Add a polling sample for CPU temperature monitor. This sample demonstrates how to data fetch and print to the console. Signed-off-by: TOKITA Hiroshi <[email protected]>
|
Add myself as codeowner of previously committed driver. - zephyrproject-rtos#53591 Signed-off-by: TOKITA Hiroshi <[email protected]>
Add myself as codeowner of previously committed driver. - #53591 Signed-off-by: TOKITA Hiroshi <[email protected]>
Add myself as codeowner of previously committed driver. - zephyrproject-rtos#53591 Signed-off-by: TOKITA Hiroshi <[email protected]>
Support for the measuring the CPU die temperature
for the RaspberryPi Pico.
Signed-off-by: TOKITA Hiroshi [email protected]