kernel: posix: implement schedule related APIs for POSIX. #5510
Conversation
Map Zephyr APIs to Posix APIs corresponding to scheduler. Signed-off-by: Youvedeep Singh <[email protected]>
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| #include <stdint.h> |
There was a problem hiding this comment.
There's no need to include stdint.h here: this header file is not using any definition from this header. Add the #include directive to the implementation file, if required there. Also, please add an include guard.
| #include <pthread.h> | ||
|
|
||
| /* | ||
| * ======== sched_get_priority_min ======== |
There was a problem hiding this comment.
Please provide the documentation in the header file, using the Doxygen format.
| return -EINVAL; | ||
| } | ||
| #if defined(CONFIG_COOP_ENABLED) && defined(CONFIG_PREEMPT_ENABLED) | ||
| priority = (policy == SCHED_COOP) ? (-1 * -1) : |
|
|
||
| int priority = -EINVAL; | ||
|
|
||
| if (!((policy == CONFIG_COOP_ENABLED) || (policy == SCHED_PREMPT))) { |
There was a problem hiding this comment.
CONFIG_COOP_ENABLED sounds like a Zephyr thing, rather than a POSIX thing. Is it correct here?
| @@ -0,0 +1,15 @@ | |||
| /* | |||
There was a problem hiding this comment.
These definitions are in a file named <sched.h>; shouldn't them be in a file with the same name so that code that assumes this will be able to find them without change?
| priority = (policy == SCHED_PREMPT) ? K_LOWEST_APPLICATION_THREAD_PRIO : | ||
| -EINVAL; | ||
| #endif | ||
| return priority; |
There was a problem hiding this comment.
These functions will return -1 on error, and the priority on success. It's returning a negative errno on error.
| @@ -0,0 +1,15 @@ | |||
| /* | |||
| * Copyright (c) 2017 Intel Corporation | |||
There was a problem hiding this comment.
Now that it's 2018, these copyright headers need updating when (significant) changes are made, right?
There was a problem hiding this comment.
I've personally never received any guidance that this is necessary.
| * returns: priority corresponing to policy | ||
| * -EINVAL for Error | ||
| */ | ||
| int sched_get_priority_min(int policy) |
There was a problem hiding this comment.
This function can be simplified by using the IS_ENABLED() macro. Not complete, of course, just something to consider:
int sched_get_priority_min(int policy)
{
if (IS_ENABLED(CONFIG_COOP_ENABLED)) {
if (priority == SCHED_COOP) {
return K_LOWEST_APPLICATION_THREAD_PRIO;
}
}
if (IS_ENABLED(CONFIG_PREEMPT_ENABLED)) {
if (priority == SCHED_PREEMPT) {
return K_LOWEST_APPLICATION_THREAD_PRIO;
}
}
errno = EINVAL;
return -1;
}
Map Zephyr APIs to Posix APIs corresponding to scheduler.
Signed-off-by: Youvedeep Singh [email protected]