tests: net: socketpair: resolve include order issues #55760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `socketpair()` tests had pulled in the native `fcntl()` implementation instead of using the Zephyr version when being run under `native_posix_64`. Signed-off-by: Christopher Friedt <[email protected]>
cfriedt
force-pushed
the
issues/54996/net-socketpair-fcntl-non-functional-with-socketpair-provided-sockets-on-posix-arch
branch
2 times, most recently
from
779153d to
ba52b72
Compare
This reverts commit 2eb53f4. Signed-off-by: Christopher Friedt <[email protected]>
cfriedt
force-pushed
the
issues/54996/net-socketpair-fcntl-non-functional-with-socketpair-provided-sockets-on-posix-arch
branch
from
ba52b72 to
c09a812
Compare
rlubos
approved these changes
Mar 15, 2023
stephanosio
approved these changes
Mar 15, 2023
cfriedt
deleted the
issues/54996/net-socketpair-fcntl-non-functional-with-socketpair-provided-sockets-on-posix-arch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that socketpair tests were not passing on
native_posixdue to what seems to be an ordering issue in include paths. Normally, system include paths are searched first, and then paths added with-I<path>.When running the Zephyr testsuite, explicitly use the
<zephyr/posix/fcntl.h>header to avoid ambiguity. In the future, we there might be a more elaborate scheme for removing ambiguity fornative_posix.Fixes #54996