drivers/spi: Properly check for rx/tx and buffering on #5785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 23, 2018
Codecov Report
@@ Coverage Diff @@
## master #5785 +/- ##
==========================================
- Coverage 54.37% 54.32% -0.06%
==========================================
Files 457 457
Lines 43298 43298
Branches 8302 8302
==========================================
- Hits 23545 23521 -24
- Misses 19612 19638 +26
+ Partials 141 139 -2
Continue to review full report at Codecov.
|
nzmichaelh
requested changes
Jan 24, 2018
| static ALWAYS_INLINE | ||
| bool spi_context_rx_buf_on(struct spi_context *ctx) | ||
| { | ||
| return !!(ctx->rx_buf && ctx->rx_len); |
There was a problem hiding this comment.
Hi @tbursztyka this might break the stm32 driver. Inside the shift-next-byte loop, the stm32 does the following:
data = read byte
if spi_context_rx_on(...) {
*ctx.rx_buf = data
spi_context_update_rx(...)
}
With this change, the above code will fail when rx_buf.buf = NULL and rx_buf.len > 0.
WDYT about documenting the spi_context API then we can go through and fix the current users?
There was a problem hiding this comment.
I have already pushed a commit to fix it in PR #5413.
nzmichaelh
approved these changes
Jan 27, 2018
Current buffers might be configured to skip data, thus only len will be set, buf will be NULL. Buffer should be used if only len is > 0 and buffer is valid as well. tx/rx are "on" if len is > 0 tx/rx buf should be touched if only len is > 0 _and_ buf != NULL. Signed-off-by: Tomasz Bursztyka <[email protected]>
nashif
force-pushed
the
spi_context_fix
branch
from
ab30dc0 to
f0ee1d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current buffers might be configured to skip data, thus only len will be
set, buf will be NULL. Buffer should be used if only len is > 0 and
buffer is valid as well.
tx/rx are "on" if len is > 0
tx/rx buf should be touched if only len is > 0 and buf != NULL.
Signed-off-by: Tomasz Bursztyka [email protected]