Fix misc issues and enable v8r64 FPU #58056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povergoing
requested review from
dcpleung,
andyross,
nashif,
carlescufi,
galak,
MaureenHelm and
carlocaione
as code owners
carlocaione
reviewed
May 19, 2023
include/zephyr/spinlock.h
Outdated
Comment on lines
156
to
159
| #if defined(CONFIG_ARM64) && defined(CONFIG_FPU_SHARING) | ||
| extern void z_arm64_flush_local_fpu_proactive(void); | ||
| z_arm64_flush_local_fpu_proactive(); | ||
| #endif |
There was a problem hiding this comment.
uhm, this could raise some eyebrows. Can you detach this from this PR and make a standalone PR only for this?
There was a problem hiding this comment.
Yes I will, and I also expect there is a better way to fix the issue
|
This PR depends on #58058. I will rebase this when we get a solution |
|
@povergoing: The deadlock is a very interesting one. |
… size The test case will show an unexpected exception in the idle thread after all test cases pass. The issue is caused by the main thread stackoverflow. Increase the main stack configured in this test case to fix the issue. Signed-off-by: Jaxson Han <[email protected]>
LOG system has unalignment access instruction which will cause an alignment exception before MPU is enabled. Remove the LOG print before MPU is enabled to avoid this issue. Signed-off-by: Jaxson Han <[email protected]>
Each core should init their own stack during the reset when SMP enabled, but do not touch others. The current init results in each core starting init the stack from the same address which will break others. Fix the issue by setting a correct start address. Signed-off-by: Jaxson Han <[email protected]>
cpu_node_list does not hold the corrent mapping of cpu id and mpid when core booting sequence does not follow the DTS cpu node sequence. This will cause an issue that sgi cannot deliver to the right target. Add the cpu_map array to hold the corrent mapping between cpu id and mpid. Signed-off-by: Jaxson Han <[email protected]>
This commit is to enable FPU and FPU_SHARING for v8r aarch64. Signed-off-by: Jaxson Han <[email protected]>
povergoing
force-pushed
the
fix_misc_and_enable_v8r64_fpu
branch
from
7ad8e46 to
dbace5c
Compare
|
I think this is ready for review :) |
npitre
approved these changes
May 29, 2023
SgrrZhf
approved these changes
May 30, 2023
carlocaione
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues and enables the FPU for v8R AArch64
Fix text exception by increasing the stack size
Remove LOG print before MPU is enabled to avoid the potential un-alignment instruction called before MPU is enabled.
Fix the STACK_INIT during the reset
Add cpu_map to have a correct mapping of CPU id and MPID
Fix a deadlock case when using FPU in the spin-locked section (this workaround fixes modified the spinlock, RFC)fix possible deadlock with FPU sharing on ARM64 and RISC-V #58086 fixed the deadlock issueUsing FPU with FPU sharing in a spin-locked critical section might cause a 'deadlock'. When core 0 got a spinlock that other cores are waiting for, it will 'deadlock' if the core 0 current threads' FPU context is living in another one that is waiting for the spinlock but never receives the FPU IPI. CC @npitre
Enable FPU and FPU_SHARING for v8r aarch64
Tested on all runnable Arm64 platforms including
fvp_baser_aemv8randfvp_baser_aemv8r_smp