Skip to content

manifest: update LVGL to v8.3.7 #59656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2023
Merged

manifest: update LVGL to v8.3.7 #59656

merged 2 commits into from
Jul 10, 2023

Conversation

faxe1008
Copy link
Collaborator

@zephyrbot zephyrbot added manifest manifest-lvgl DNM This PR should not be merged (Do Not Merge) labels Jun 23, 2023
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jun 23, 2023 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
lvgl zephyrproject-rtos/lvgl@7102083 zephyrproject-rtos/lvgl@f7cf01d (zephyr) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@faxe1008 faxe1008 mentioned this pull request Jun 23, 2023
Closed
@pdgendt
Copy link
Collaborator

pdgendt commented Jun 26, 2023

@faxe1008 thanks for putting the effort in this, can you update the sample as discussed in #53974 as well here?

@faxe1008 faxe1008 requested a review from nashif as a code owner June 26, 2023 09:19
@zephyrbot zephyrbot requested review from brgl and pdgendt June 26, 2023 09:20
@faxe1008
Copy link
Collaborator Author

@pdgendt I am not sure what sample you are refering to. According to the discussion with @kisvegabor in pull/53974#issuecomment-1606850642 I changed the order of operations in the twister tests in the zephyr repo (this PR), since the test should not have worked like this in the first place. The sample located at samples/subsys/display/lvgl builds just fine for me.

@faxe1008 faxe1008 force-pushed the update_lvgl_8.3.7 branch from 8e50298 to c5a5ef4 Compare June 26, 2023 09:24
@pdgendt
Copy link
Collaborator

pdgendt commented Jun 26, 2023

@pdgendt I am not sure what sample you are refering to.

I meant the test, it's fine now.

@faxe1008 faxe1008 force-pushed the update_lvgl_8.3.7 branch from c5a5ef4 to 3544486 Compare June 26, 2023 16:46
@faxe1008
Copy link
Collaborator Author

Fixed a typo in last commit message :^)

pdgendt
pdgendt previously approved these changes Jun 26, 2023
View reviewed changes
@pdgendt pdgendt added the area: LVGL Light and Versatile Graphics Library Support label Jun 30, 2023
kartben
kartben previously approved these changes Jul 10, 2023
View reviewed changes
@carlescufi
Copy link
Member

@faxe1008 zephyrproject-rtos/lvgl#41 is now merged, you can now switch to a SHA revision

faxe1008 added 2 commits July 10, 2023 13:37
@faxe1008
manifest: update LVGL to v8.3.7
4257480 
Related to zephyrproject-rtos/lvgl#41

Signed-off-by: Fabian Blatz <[email protected]>
@faxe1008
tests: lib: gui: lvgl: Reorder screen load and delete
17e3d9b 
Load the default screen before the deleting the newly created one.
This used to work in LVGL 8.2.0 but was not intended according to the
discussion in zephyrproject-rtos#53974.

Signed-off-by: Fabian Blatz <[email protected]>
@faxe1008 faxe1008 dismissed stale reviews from kartben and pdgendt via 17e3d9b July 10, 2023 11:37
@faxe1008 faxe1008 force-pushed the update_lvgl_8.3.7 branch from 3544486 to 17e3d9b Compare July 10, 2023 11:37
@faxe1008
Copy link
Collaborator Author

@carlescufi I updated the src rev :^)

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jul 10, 2023
@carlescufi carlescufi merged commit ec46da4 into zephyrproject-rtos:main Jul 10, 2023
@danieldegrasse danieldegrasse mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kartben kartben kartben approved these changes

@pdgendt pdgendt pdgendt approved these changes

@carlescufi carlescufi carlescufi approved these changes

@jfischer-no jfischer-no Awaiting requested review from jfischer-no

@gmarull gmarull Awaiting requested review from gmarull

@fkokosinski fkokosinski Awaiting requested review from fkokosinski

@nashif nashif Awaiting requested review from nashif

@brgl brgl Awaiting requested review from brgl

Assignees
No one assigned
Labels
area: LVGL Light and Versatile Graphics Library Support manifest manifest-lvgl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@faxe1008 @zephyrbot @pdgendt @carlescufi @kartben