posix: implement timer_getoverrun() #60171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfriedt
reviewed
Jul 9, 2023
include/zephyr/posix/time.h
Outdated
| @@ -77,6 +77,10 @@ extern "C" { | |||
| #define TIMER_ABSTIME 4 | |||
| #endif | |||
|
|
|||
| #ifndef DELAYTIMER_MAX | |||
| #define DELAYTIMER_MAX 20 | |||
There was a problem hiding this comment.
If you remove the #ifndef, does it break anything? That would be better if possible.
Also, it might make more sense to create a Kconfig option for this rather than hard-coding it.
e.g.
if TIMER
config POSIX_TIMER_DELAYTIMER_MAX
int "Maximum count returned by timer_getoverrun()"
default 20
help
...
endif
There was a problem hiding this comment.
If you remove the #ifndef, does it break anything? That would be better if possible.
It does not break anything.
Address missing POSIX function and tests zephyrproject-rtos#59956 Signed-off-by: Harshil Bhatt <[email protected]>
harshilbhatt2001
force-pushed
the
posix_timer
branch
from
54208fc to
92745b5
Compare
cfriedt
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address missing POSIX function and tests
Fixes #59956